Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wishlist: support no login and no confirm #8

Open
ftoledo opened this issue Jul 13, 2024 · 1 comment
Open

wishlist: support no login and no confirm #8

ftoledo opened this issue Jul 13, 2024 · 1 comment

Comments

@ftoledo
Copy link

ftoledo commented Jul 13, 2024

Hi, i found your app very cool
I would like it not to be necessary for each person to register, but rather for a list to be uploaded.
Likewise, the possibility of avoiding confirming the score.
The idea behind it is that it uses a single person to screw up and keep score.
Is this possible with your code? or should it be modified a lot?
thanks!

@kostrykin
Copy link
Collaborator

Thanks for your feedback!

As far as I see on the hoof, the core issue is to losen the direct coupling of the Participation class with auth.User objects:
https://github.com/kostrykin/tournaments/blob/035ddc2af888b6ee20fab7dc652934414c55fd76/tournaments/tournaments/models.py#L204

Instead, we would need an extra Participant class, which has a nullable foreign reference to auth.User, and which the Participation class would be directly coupled with.

In required_participations_count only those participants would need to be counted, which have a non-null auth.User associated with them:
https://github.com/kostrykin/tournaments/blob/035ddc2af888b6ee20fab7dc652934414c55fd76/tournaments/tournaments/models.py#L849

I think that this would be pretty much it. Maybe there would also be some frontend stuff, which would require some updates. The tricky part would be to write the migrations and the hardest part would be to write the tests.

If you are willing to do that, feel free to make a Pull Request, and I'd gladly assist you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants