Support of React-Redux 6.0.0

[bini1988]

Hello,
I am trying to use latest react@16.7.0 and react-redux@6.0.0 modules with React Konva and I get errors:

browser.js:38 Uncaught Error: Could not find "store" in the context of "Connect(Component)". Either wrap the root component in a , or pass a custom React context provider to and the corresponding React context consumer to Connect(Component) in connect options.

It seems that React Konva goes wrong when I use redux connect function with konva shapes.
Reproducible demo: https://codesandbox.io/s/v6v2znvqql

[lavrton]

The code above works with react-redux v5. react-redux is changed underlying context mechanism.

The issue should be related to #188

[TimmyGOGO]

Same problem. I have a wrapped in a <Portal> element "PopoverContainer" on <Stage>. And I wanted to transfer logic with handling events and redux actions to another file, but then got an error of:

Uncaught Error: Could not find "store" in the context of "Connect(PopoverContainer)". Either wrap the root component in a , or pass a custom React context provider to and the corresponding React context consumer to Connect(PopoverContainer) in connect options.

Is it possible to make it work if we wrap Component in <Provider store={this.props.store}>...</Provider>?

[TimmyGOGO]

I tried to pass redux store as a prop to Components, but faced next problem:

react-dom.development.js:55 Uncaught Error: Element type is invalid: expected a string (for built-in components) or a class/function (for composite components) but got: undefined. You likely forgot to export your component from the file it's defined in, or you might have mixed up default and named imports.

I suggest this is because I pass store to a decorated Component, which is exported like this:
export default connect( mapToStateProps, mapDispatchToProps )(Component);

[lavrton]

The current workaround is to bridge store in Stage component.

import { ReactReduxContext, Provider } from "react-redux";


       // later in render:
      <ReactReduxContext.Consumer>
        {({ store }) => (
          <Stage width={window.innerWidth} height={window.innerHeight}>
            <Provider store={store}>
              <Layer>
                {staticTargets.map(t => (
                  <Target target={t} key={t.id} />
                ))}
              </Layer>
              <Layer name="dragging-layer">
                {movingTargets.map(t => (
                  <Target target={t} key={t.id} />
                ))}
              </Layer>
            </Provider>
          </Stage>
        )}
      </ReactReduxContext.Consumer>

Demo: https://codesandbox.io/s/lr6n4r7o7m

[TimmyGOGO]

Thanks a lot, @lavrton!

[ArgonAlex]

It should be noted that React Redux v6 as is, using the new Context API is being rethought. They are going back to direct subscriptions with a new implementation in another release, possibly v7.

reduxjs/react-redux#1177

[markerikson]

However, we will still be using the same context mechanism as v6 to make the store available to the components. The difference will be in how the components receive updated store state values.

[veksa]

FYI:
Same problem with the context mechanism in the react-fela, and custom components with a context.
It's a little uncomfortable reuse all context providers after .

[xxlee0927]

The solution @lavrton provide may encounter the issue that child wrapped in <Provider> sometimes receive updated redux value earlier than parent. Therefore I need to perform additional condition checking to prevent bugs. Hope to have full support of context.

[lavrton]

This final note here.

react-redux is using a context mechanism to make the store available for components. But in the way react-konva is implemented, the context information is lost inside <Stage> component. react-konva is creating a "fresh renderer". So it has no information about root contexts. At the current moment, I don't see any ways to bridge this automatically.
We have to do to it manually:

import { ReactReduxContext, Provider } from 'react-redux';

const Canvas = () => {
  return (
    <ReactReduxContext.Consumer>
      {/* consume store from context */}
      {({ store }) => (
        <Stage width={window.innerWidth} height={window.innerHeight}>
          {/* inject store into context */}
          <Provider store={store}>
            <SomeCanvasComponents />
          </Provider>
        </Stage>
      )}
    </ReactReduxContext.Consumer>
  );
};

As @xxlee0927 mentioned:

The solution @lavrton provide may encounter the issue that child wrapped in sometimes receive updated redux value earlier than the parent.

And I had exactly this issue in the last project. I will try to give the full example of the issue and the solution I used to fix the error.

Let us think we have a store:

{
  wallsIds: ['v1', 'v2'],
  walls: {
    v1: { fill: 'red' },
    v2: { fill: 'blue' }
  }
}

Now we have a component that creates our drawings.

const Canvas = ({ wallsIds }) => {
  return (
    <ReactReduxContext.Consumer>
      {({ store }) => (
        <Stage width={window.innerWidth} height={window.innerHeight}>
          <Provider store={store}>
            <Layer>
              {wallsIds.map(id => <Wall id={id} />)}
            </Layer>
          </Provider>
        </Stage>
      )}
    </ReactReduxContext.Consumer>
  );
};

export default connect(store => ({ wallsIds: store.wallsIds }))(Canvas);

And we have a Wall component that connected into the store and reads its full properties (by having its id):

const Wall = ({ wall }) => {
   return <Rect fill={wall.fill} />
}

export default connect((store, props) => ({ wall: store.walls[props.id] }))(Wall);

This issue is that on store update, canvas components connected inside <Stage /> will receive new state BEFORE the parent component. That means <Wall /> will know about the update before <Canvas />. And that can produce the bug when you are trying to remove the element. Like, remove a wall with id v1 from the store. Here is how the error will happen:

On remove, the store will have no information about wall v1. <Wall /> component see the update and it is trying to update itself. On update, it reads wall information from the store: { wall: store.walls[props.id] }. But it will be undefined. So in your case, we will have an error when we are trying to read wall.fill. The <Canvas/> is not updated yet, so it still render "old" data when we still have the wall.

How we can make sure that properties are in sync?

The workaround is simple. We can't use information from the store that we received in <Canvas> components to draw something inside <Stage/>. In other words, don't use this.props for components inside <Stage />. Like we used this:

{wallsIds.map(id => <Wall id={id} />)}

wallsIds is a prop we have from the connected store.

How to rewrite this code?

We can just wrap whole content inside <Stage /> into another component:

const WallsContainer = ({ wallsIds }) => {
  return {wallsIds.map(id => <Wall id={id} />)};
};

export default connect(store => ({ wallsIds: store.wallsIds }))(WallsContainer);

And then use it instead:

<Stage width={window.innerWidth} height={window.innerHeight}>
  <Provider store={store}>
    <Layer>
      <WallsContainer />
    </Layer>
  </Provider>
</Stage>

I hope I was clear in this large message. If you still have any issues with it, please add your comment.

I am going to close the issue for now because I don't think we can do anything else at the current moment.