Adding a get sync getItems method#112
Conversation
|
This pull request only covers only the getItems method, but there is a bunch of remaining in the delivery client (i.e. getTypes). I would like to avoid doubling the method count in the delivery client. I would appreciate a unified approach. According to the tests, I would like to not have current tests modified and just add new ones, because the functionality is also just added, not modified. Mind the Readme - there should be the mention of the functionality too. |
|
@cunhazera - do you have any update on this? |
|
Hi! This pull request has gone quiet. 👻 If we missed anything on this issue or if you want to keep it open, feel free to do so. Thanks for being a part of the Kentico community! |
Fixes #109
Commentary:
toSyncmethod, because I'd need to return an instance ofDeliveryClientso the items should be stored in a field, so then I could have andeliveryClient.getItems(Class.class).toSync(). If I did this, theDeliveryClientclass would need a generic type at the class level, so that would break a lot of old code. Anyway, if anyone has a better idea we can talk about, to have atoSyncmethod.