Skip to content

Change request_iteration_count to use a GET request #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

TillerBurr
Copy link

This is the fix suggested in #44 (comment). It was tested with my personal account and it works well.

Whilst testing, I also found that changing the request to /iterations.php to a GET is not enough. The User-Agent in the header must also be changed from python/requests to something else. It doesn't matter what it's changed to. For this repo, this was already fixed in commit fad6e0c.

As noted in lastpass/lastpass-cli#604, one workaround is to change the iterations to 100100 by performing the following:

  1. Open Account Settings in your browser (Open My VaultAccount Settings)
  2. Press Show Advanced Settings
  3. Set General → Security → Password Iterations to exactly 100100

LastPass will ask for your Master password and re-encrypt your vault.

Closes #44

@codecov
Copy link

codecov bot commented May 25, 2021

Codecov Report

Merging #45 (05518e8) into master (41af73a) will not change coverage.
The diff coverage is 100.00%.

❗ Current head 05518e8 differs from pull request most recent head 5c3ddb3. Consider uploading reports for the commit 5c3ddb3 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master      #45   +/-   ##
=======================================
  Coverage   72.72%   72.72%           
=======================================
  Files          10       10           
  Lines         385      385           
=======================================
  Hits          280      280           
  Misses        105      105           
Impacted Files Coverage Δ
lastpass/fetcher.py 60.97% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 41af73a...5c3ddb3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lastpass Changed the Login Route
1 participant