fix(deps): forward compatibility with sigs.k8s.io/controller-runtime #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR unblocks #113 |
MartinBasti
force-pushed
the
fix-dep-printer
branch
from
1cf7ddf
to
d6f8b80
Compare
|
and also #109 |
package sigs.k8s.io/controller-runtime/pkg/envtest/printer will be removed in future version. Use ginko/v2 and drop that package https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0 Signed-off-by: Martin Basti <mbasti@redhat.com>
MartinBasti
force-pushed
the
fix-dep-printer
branch
from
d6f8b80
to
ac6ea70
Compare
Codecov ReportBase: 70.98% // Head: 70.24% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
- Coverage 70.98% 70.24% -0.75%
==========================================
Files 25 25
Lines 2223 2238 +15
==========================================
- Hits 1578 1572 -6
- Misses 494 512 +18
- Partials 151 154 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
MartinBasti
requested review from
hongweiliu17,
jinqi7,
Josh-Everett,
jsztuka and
dheerajodha
|
I'm not going to fix gitlint by breaking URL into 2 lines |
hongweiliu17
approved these changes
Feb 23, 2023
dheerajodha
approved these changes
Feb 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package sigs.k8s.io/controller-runtime/pkg/envtest/printer will be removed in future version.
Use ginko/v2 and drop that package
https://github.com/kubernetes-sigs/controller-runtime/releases/tag/v0.14.0