Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to RxJS 6 or add rxjs-compat dependency #29

Closed
johngrogg opened this issue Jun 8, 2018 · 4 comments
Closed

Upgrade to RxJS 6 or add rxjs-compat dependency #29

johngrogg opened this issue Jun 8, 2018 · 4 comments

Comments

@johngrogg
Copy link

When using rxjs-grpc with RxJS 6, rxjs-compat is required because of the use of the following import pattern:

import { Observable } from "rxjs/Observable";

With RxJS 6 it should be updated to:

import { Observable } from "rxjs";

See ReactiveX/rxjs#3764 for more details

@kondi kondi added this to the 1.0-rc.0 milestone Jun 8, 2018
@FedeBev
Copy link

FedeBev commented Jul 18, 2018

Look if PR #35 solve your issue!

@kondi
Copy link
Owner

kondi commented Jul 18, 2018

If you need rxjs6 support, please use rxjs-grpc@rxjs6 prerelease version.
From version 1.0-rc.0 it will be officially supported, however, there will be other breaking changes as well.

@redevill
Copy link

redevill commented Oct 9, 2018

Internally to the project, with a fresh npm install (V6.3.3) the node-modules/rxjs/util folder still refers to the rxjs-compat.

@kondi kondi closed this as completed in d629242 Mar 4, 2019
@kondi kondi removed this from the 1.0-rc.0 milestone Mar 5, 2019
@kondi
Copy link
Owner

kondi commented Mar 5, 2019

Released in v0.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants