Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better support for Bootstrap. #102

Open
jorgeepena opened this issue Aug 26, 2024 · 1 comment
Open

Better support for Bootstrap. #102

jorgeepena opened this issue Aug 26, 2024 · 1 comment
Labels
question Further information is requested

Comments

@jorgeepena
Copy link

The theme has alot of unique clases that modify the base boostrap file. Would be positive to depend solely on bootstrap to enhance the personalization via custom.css file.

Ex:
Using "col-desktop-3" gives the element 16% width that is not consistent with boostraps original "col-md-3" that would give you 33% width. And theres a class called "rows-col-3" that does have the 33% width but the usage is not clear.

@alvinkonda
Copy link
Contributor

alvinkonda commented Aug 26, 2024

Hi Jorge,

You are right, we have modified a bit the bootstrap scss codes which you can check here
https://github.com/kondasoft/ks-bootshop/blob/master/src/bootstrap.scss

The most important changes are the spacing utiliiesp-, m- and the responsive utilities (grid-breakpoints) that you have mentioned above, and that's because we think the theme performs better that way. But since we provide the bootstrap source file you may adjust those options if you prefer so.

Let me know if you have additional questions about this.

@alvinkonda alvinkonda added the question Further information is requested label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants
@alvinkonda @jorgeepena and others