Skip to content

Conversation

@NansPellicari
Copy link

Provides a more effective way to compare and updates previous/next blocks state.
Allows to undo/redo multiple blocks.

@NansPellicari NansPellicari force-pushed the fix/undo-redo-behavior branch 2 times, most recently from c4f409f to dd7f91f Compare February 14, 2025 13:22
Copy link

@IhorKirei IhorKirei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@L-Zuluaga L-Zuluaga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @NansPellicari Thank you for your contribution to this project! I really appreciate the time and effort you put into including these valuable improvements. Everything looks good.
Upon review—just make sure your commits have verified signatures for approval.

Looking forward to your update!

@NansPellicari
Copy link
Author

hi @NansPellicari Thank you for your contribution to this project! I really appreciate the time and effort you put into including these valuable improvements. Everything looks good. Upon review—just make sure your commits have verified signatures for approval.

Looking forward to your update!

It's done!

L-Zuluaga
L-Zuluaga previously approved these changes Feb 28, 2025
@L-Zuluaga L-Zuluaga linked an issue Feb 28, 2025 that may be closed by this pull request
@NansPellicari
Copy link
Author

HI @L-Zuluaga & @IhorKirei, do you know what is the process to go to the merge step for this PR ?
I have to finish this PR #287, and it depends on this one, it would be great to have this one merged first before achieving the other.

@L-Zuluaga
Copy link
Member

Hi @NansPellicari sure, just go ahead and merge using Squash and Merge strategy, after that we can proceed to prepare the release of the next version.

@NansPellicari
Copy link
Author

Hi @NansPellicari sure, just go ahead and merge using Squash and Merge strategy, after that we can proceed to prepare the release of the next version.

OK thanks for your response! But I don't think I have the rights to do it by myself, I don't have any buttons for doing it

@L-Zuluaga L-Zuluaga changed the base branch from main to v2.0 March 11, 2025 14:23
@L-Zuluaga L-Zuluaga dismissed their stale review March 11, 2025 14:23

The base branch was changed.

@L-Zuluaga
Copy link
Member

@NansPellicari I just changed the target branch, can you confirm if now you are able to merge now?

@NansPellicari
Copy link
Author

@NansPellicari I just changed the target branch, can you confirm if now you are able to merge now?

Thanks for that, no i still can't 😞

@L-Zuluaga
Copy link
Member

@NansPellicari That’s quite strange—let me review what’s happening. In the meantime, I noticed that there are commits in the PR that shouldn’t be there, probably because of the target branch change, can you take a look please?
image

@NansPellicari
Copy link
Author

@NansPellicari That’s quite strange—let me review what’s happening. In the meantime, I noticed that there are commits in the PR that shouldn’t be there, probably because of the target branch change, can you take a look please? image

Sure, i'll managed that in the evening, i'm quitte busy today. I'll keep you in touch

@NansPellicari NansPellicari force-pushed the fix/undo-redo-behavior branch from a744ce2 to 18d7734 Compare March 17, 2025 13:19
@NansPellicari NansPellicari force-pushed the fix/undo-redo-behavior branch from 18d7734 to 38ca5a8 Compare March 17, 2025 13:24
@NansPellicari
Copy link
Author

@NansPellicari That’s quite strange—let me review what’s happening. In the meantime, I noticed that there are commits in the PR that shouldn’t be there, probably because of the target branch change, can you take a look please? image

Hi @L-Zuluaga,
Sorry for the delay, I've just pushed the branch rebased on the v2.0 origin. I still can't squash & merge

@L-Zuluaga L-Zuluaga merged commit 7e6eb91 into kommitters:v2.0 Mar 17, 2025
3 checks passed
@L-Zuluaga
Copy link
Member

@NansPellicari I have merged PR, so you can proceed to adjust #287 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When removing multiple blocks, Ctrl+Z doesn't return all of them

3 participants