Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator!= for layout_{left|right} is missing when C++20 isn't available #197

Closed
youyu3 opened this issue Oct 13, 2022 · 0 comments
Closed

operator!= for layout_{left|right} is missing when C++20 isn't available #197

youyu3 opened this issue Oct 13, 2022 · 0 comments

Comments

@youyu3
Copy link
Contributor

youyu3 commented Oct 13, 2022

The check for MDSPAN_HAS_CXX_20 is incorrect. Should be #if !(MDSPAN_HAS_CXX_20).
youyu3 added a commit to youyu3/libcudacxx that referenced this issue Oct 13, 2022
@youyu3
Fixes a couple of issues in layout_{left|right}
6256a89 
* `throw` is not supported in device code, uses `assert` instead
* Converts `stride` of the other `mapping` into `size_t` before comparing the values, to avoid possible warning (error when `-Werror=sign-compare` is on)
* Fixes `operator!=` which is missing when C++20 isn't available (kokkos/mdspan#197)
youyu3 added a commit to youyu3/mdspan that referenced this issue Jan 6, 2023
@youyu3
Fix the inequality operator in layout_left and layout_right, after ko…
6b12cf2 
…kkos#197
crtrott added a commit that referenced this issue Jan 6, 2023
@crtrott
Merge pull request #225 from youyu3/fix-197-layout-left-right-inequality
ad014fa 
Fix the inequality operator in layout_left and layout_right, after #197
@crtrott crtrott closed this as completed Jan 31, 2023
mhoemmen added a commit to mhoemmen/mdspan that referenced this issue Jul 26, 2023
@mhoemmen
Merge pull request kokkos#197 from NexGenAnalytics/gemm_kokkos_impl
c583682 
[ready] kokkos impl `gemm`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crtrott @youyu3