Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-Resolution Noise #471

Merged
merged 1 commit into from
May 3, 2023
Merged

Multi-Resolution Noise #471

merged 1 commit into from
May 3, 2023

Conversation

pamparamm
Copy link
Contributor

@pamparamm pamparamm commented May 2, 2023

Support for multi-resolution noise (pyramid noise implementation by Jonathan Whitaker)
Works fine with LoRA and LyCORIS, haven't tested with other training approaches.
Adds new arguments: --multires_noise_iterations to enable multires noise (recommended values are 6-10), and --multires_noise_discount (recommended value by Jonathan is 0.8. I find that value too high for LoRAs with small datasets, so I would recommend something around 0.1-0.3).

Resolves #334

@kohya-ss
Copy link
Owner

kohya-ss commented May 2, 2023

Thank you for this! This is interesting, and the implementation looks quite good! I will test and merge as soon as I have time.

@kohya-ss kohya-ss changed the base branch from main to dev May 3, 2023 02:17
@kohya-ss kohya-ss merged commit 2e688b7 into kohya-ss:dev May 3, 2023
@kohya-ss
Copy link
Owner

kohya-ss commented May 3, 2023

I've merged. Thank you again for this!

@bmaltais
Copy link
Contributor

bmaltais commented May 3, 2023

@kohya-ss and @pamparamm Quick question... when using multi-res should the original noise option be left to 0... or is it still required to be set?

@pamparamm
Copy link
Contributor Author

@bmaltais According to #477 you can't set both noise_offset and multires_noise_iterations as they both enable different noise techniques.

@bmaltais bmaltais mentioned this pull request May 5, 2023
@feffy380
Copy link
Contributor

feffy380 commented May 8, 2023

@pamparamm Can you post some examples showing the effect of this option?

@johnowhitaker
Copy link

Oh cool! Fun to see this in use. 0.8 was from early tests and I've since (like you) figured out that much lower values work better :)

wkpark pushed a commit to wkpark/sd-scripts that referenced this pull request Feb 27, 2024
…alpha

Change step of network_alpha from 1 to 0.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Multi-Resolution Noise
5 participants