Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Lion8bit #447

Merged
merged 34 commits into from
May 3, 2023
Merged

Support for Lion8bit #447

merged 34 commits into from
May 3, 2023

Conversation

sdbds
Copy link
Contributor

@sdbds sdbds commented Apr 25, 2023

test bitsandbytes 0.38.1 for lion8bit
#443

@sdbds sdbds changed the title Support for Lion8bi Support for Lion8bit Apr 25, 2023
@sdbds
Copy link
Contributor Author

sdbds commented Apr 25, 2023

bdc4543e86fc5a2b487b835ab5e2c30

ok,tested well.
lion8bit is a bit faster than lion.

anyone want to try this?

@sdbds sdbds changed the base branch from main to dev April 25, 2023 05:34
@sdbds sdbds marked this pull request as ready for review April 25, 2023 05:35
@kohya-ss
Copy link
Owner

Thank you for this! Lion8bit is quite interesting!

One concern I have is the stability of the new version of bitsandbytes. If there is some problem in training, it will affect many people. So I think it might be a good idea to make it an optional choice for a while. In other words, keep the default installation guide and add an optional guide for using the new bitsandbytes for those who want it..

I am also concerned about the source of the DLL. As for the license, I think the bitsandbytes binary is probably the same as the license of the original repository. But there might be some unexpected problem.
(Maybe I'm being too paranoid, for example, malware.)

I would appreciate it if you could tell me where to find it.

I really wish I could build it myself, but it's not easy...

@sdbds
Copy link
Contributor Author

sdbds commented Apr 25, 2023

Thank you for this! Lion8bit is quite interesting!

One concern I have is the stability of the new version of bitsandbytes. If there is some problem in training, it will affect many people. So I think it might be a good idea to make it an optional choice for a while. In other words, keep the default installation guide and add an optional guide for using the new bitsandbytes for those who want it..

I am also concerned about the source of the DLL. As for the license, I think the bitsandbytes binary is probably the same as the license of the original repository. But there might be some unexpected problem. (Maybe I'm being too paranoid, for example, malware.)

I would appreciate it if you could tell me where to find it.

I really wish I could build it myself, but it's not easy...

Thank you for replying!
yeah,new version maybe not stable,we can just put it for optional

I found bitsandbytes 0.38.1 dll in here.
https://github.com/jllllll/bitsandbytes-windows-webui
Its author says he made form here
https://github.com/jllllll/bitsandbytes/tree/cmake_windows
Your concern is correct, it's better to compile a secure version from the above fork,it is esay to make with modified Windows version.

i tried to build it too,too hard...

@kohya-ss
Copy link
Owner

Thank you for your understanding! and once we confirm the stability of the new version of bitsandbytes, we will make that the default.

Thanks also for the information about bitsandbytes DLL. It looks very good. I will try again to build from the fork :)

@kohya-ss
Copy link
Owner

Thanks for all the updates!

I was able to successfully build the dll of bitsandbytes based on the repository you listed. However, I am not sure if the dll will work in all environments.

I may have been somewhat paranoid😅. It looks like we can use the dll from that repository.

Also, there seems to be a pre-built wheel for Windows in the repository from which the repository was forked. How about using this one? With this, we don't need copy dlls and modify sources.

https://github.com/acpopescu/bitsandbytes/releases

@sdbds
Copy link
Contributor Author

sdbds commented Apr 29, 2023

Thanks for all the updates!

I was able to successfully build the dll of bitsandbytes based on the repository you listed. However, I am not sure if the dll will work in all environments.

I may have been somewhat paranoid😅. It looks like we can use the dll from that repository.

Also, there seems to be a pre-built wheel for Windows in the repository from which the repository was forked. How about using this one? With this, we don't need copy dlls and modify sources.

https://github.com/acpopescu/bitsandbytes/releases

I think this is pretty good too, I did it this way, just using one of the dlls which biult form cuda118.

image

The only difference between these two forks is the correction of the CUDA loading path.

@kohya-ss
Copy link
Owner

kohya-ss commented May 2, 2023

Thank you for your comment and sorry for the delay. The difference seems to be related to compilation only, so I think we can use the wheel in acpopescu's repo.

In order to make the selection of the version of bitsandbytes optional, would it be possible for you to restore the contents of bitsandbytes_windows folder and the requirements.txt?

Then I think we can add the optional instruction for using the wheel.

Thank you again for your work!

@sdbds
Copy link
Contributor Author

sdbds commented May 2, 2023

Thank you for your comment and sorry for the delay. The difference seems to be related to compilation only, so I think we can use the wheel in acpopescu's repo.

In order to make the selection of the version of bitsandbytes optional, would it be possible for you to restore the contents of bitsandbytes_windows folder and the requirements.txt?

Then I think we can add the optional instruction for using the wheel.

Thank you again for your work!

OK!i had reversed them only change for lion8bit for trainuntil

@kohya-ss
Copy link
Owner

kohya-ss commented May 2, 2023

Thank you for your quick and hard work! I will merge as soon as possible.

@kohya-ss kohya-ss merged commit 335b2f9 into kohya-ss:dev May 3, 2023
@kohya-ss
Copy link
Owner

kohya-ss commented May 3, 2023

I've merged and released. If you notice any issue for the instruction in README, please let me know. Thank you for this!

@bmaltais bmaltais mentioned this pull request May 5, 2023
@Ashoka74
Copy link

Ashoka74 commented May 7, 2023

Hey! Thank you for this issue!

I am trying to install bitsandbytes on cuda 11.8 on my Windows for another app but am stuck here as well.
Is there a way you could share your bitsandbytes weights for cuda 11.8? @sdbds

@sdbds
Copy link
Contributor Author

sdbds commented May 7, 2023

Hey! Thank you for this issue!

I am trying to install bitsandbytes on cuda 11.8 on my Windows for another app but am stuck here as well. Is there a way you could share your bitsandbytes weights for cuda 11.8? @sdbds

i dont have some special action for it , just install Windows version in here
if you give some images about it , maybe i can give some suggestions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants