Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish to npm #41

Closed
kylejrp opened this issue Apr 11, 2019 · 13 comments
Closed

Publish to npm #41

kylejrp opened this issue Apr 11, 2019 · 13 comments
Milestone

Comments

@kylejrp
Copy link
Collaborator

kylejrp commented Apr 11, 2019

It might be nice to have water.css published to npm with every release. Then, users can install it using npm install water.css and include it in their projects without referencing a CDN.

This would mean we would have to update the package.json version semantically with every release as well.

@kognise
Copy link
Owner

kognise commented Apr 11, 2019

Great idea! I'm not that familiar with CSS frameworks being in an NPM package, so I'll research how that works.

On an unrelated note - thanks for all the help and great ideas you've contributed to Water.css. Do you mind if I make you a collaborator on the repo? This way you'll get cool access to more things (and also get nice badge next to your name iirc).

@kognise
Copy link
Owner

kognise commented Apr 11, 2019

Ok, it seems CSS is usually just included like normal in the static markup at node_modules/water.css/etc.... Pretty simple.

@kognise
Copy link
Owner

kognise commented Apr 11, 2019

So, the water.css package name on NPM is available, but here's something that could be better!

The package water has one version and was last published 7 years ago by a guy who doesn't contribute to basically anything. It seems to be some very specific code without any documentation that works with something else he's written, but it's obviously not used by anything anymore.

I think it'd be possible to contact NPM and get publish rights to this package - do you think if this is possible water is a better package name than water.css?

@Ryois
Copy link

Ryois commented Apr 11, 2019

So, the water.css package name on NPM is available, but here's something that could be better!

The package water has one version and was last published 7 years ago by a guy who doesn't contribute to basically anything. It seems to be some very specific code without any documentation that works with something else he's written, but it's obviously not used by anything anymore.

I think it'd be possible to contact NPM and get publish rights to this package - do you think if this is possible water is a better package name than water.css?

Personally I prefer water.css as the package name. One is that your github repo's name is water.css, also to get publishing rights to the package, it has to have not seen any downloads/ activity in the last few months.

@kylejrp
Copy link
Collaborator Author

kylejrp commented Apr 12, 2019

Yep, I agree, I'm a bigger fan of water.css.

On an unrelated note - thanks for all the help and great ideas you've contributed to Water.css. Do you mind if I make you a collaborator on the repo? This way you'll get cool access to more things (and also get nice badge next to your name iirc).

Absolutely, thanks for working with me on all the contributions! I'd love to be a collaborator. Thanks! 🎉

@kognise
Copy link
Owner

kognise commented Apr 12, 2019

@kylejrp Great, thanks! Yeah, I agree that water.css is probably better.

Also, here's an invite link (if GitHub is working :).

@atilacamurca
Copy link

I suggest the use of https://github.com/sindresorhus/np, great tool for automate the publish process.

@kognise
Copy link
Owner

kognise commented Apr 16, 2019

@atilacamurca Yeah, it is a great tool! Although, a lot of what that does we already do, it might not be optimal for this project. I've also had some issues with it in the past.

@chinanf-boy
Copy link

chinanf-boy commented Apr 21, 2019

I think the simple package.json template of css file is the normalize.css - package.json

{
  "name": "normalize.css",
  "version": "8.0.1",
  "description": "A modern alternative to CSS resets",
  "main": "normalize.css",
  "style": "normalize.css",
  "files": [
    "LICENSE.md",
    "normalize.css"
  ],
  "repository": "necolas/normalize.css",
  "license": "MIT",
  "bugs": "https://github.com/necolas/normalize.css/issues",
  "homepage": "https://necolas.github.io/normalize.css"
}

May just replace normalize.css path with dist files, it would Work?

@kognise kognise mentioned this issue Apr 27, 2019
@kognise
Copy link
Owner

kognise commented Apr 27, 2019

@chinanf-boy Thanks! I made some changes over in #64.

@FDiskas

This comment has been minimized.

@mdesantis

This comment has been minimized.

@kognise
Copy link
Owner

kognise commented May 27, 2020

Moving the conversation to #187

@kognise kognise closed this as completed May 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants