Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

offers should change updatedAt #91

Open
petersopko opened this issue Sep 30, 2022 · 0 comments
Open

offers should change updatedAt #91

petersopko opened this issue Sep 30, 2022 · 0 comments

Comments

@petersopko
Copy link
Contributor

  1. Recently Interacted and Unpopular are doing the same thing as Recently Created and Oldest. The reason for this (as far as I can tell) is that activity such as Offer isn't changing the updatedAt of the NFT, therefore, the NFT get's updated only once and that's when it's created. This filter was created to sort by emotes -> this is irrelevant on BSX and we should hide it on both /snek and /bsx (I've checked just now and all of the Basilisk NFTs have updatedAt and createdAt are equal everywhere, regeradless of activity)
  2. Serial Number Ascending - in my opinion, this filter is more of a mystery than any added value -> I don't think people know what is this for and I don't think they care for having it. Oldest should be enough to sort by createdAt -> let's hide this on both /snek and /bsx

Originally posted by @petersopko in kodadot/nft-gallery#3138 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant