Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Warning message equal_opportunity_score does not correspond to actual condition #417

Open
janvdvegt opened this issue Oct 8, 2020 · 1 comment
Open

[BUG] Warning message equal_opportunity_score does not correspond to actual condition #417

janvdvegt opened this issue Oct 8, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@janvdvegt
Copy link
Contributor

In the equal_opportunity_score there are two warnings that can be thrown when either y_given_z1_y1 or y_given_z0_y1 is empty. The warning messages say that there are no predictions with the positive target for the positive or negative sensitive columns, this does not need to be the case though because there is an additional filter with only the true positive samples.

f"No samples with y_hat == {positive_target} for {sensitive_column} == 1, returning 0"

could become

f"No samples with y_hat == {positive_target} for {sensitive_column} == 1 and y_true == {positive_target}, returning 0"

Same for the negative case.
@janvdvegt janvdvegt added the bug Something isn't working label Oct 8, 2020
@koaning
Copy link
Owner

koaning commented Oct 9, 2020

Adding extra information to an error message seems totally fine to me. Feel free to make the PR. @MBrouns, comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@koaning @janvdvegt