Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggest installing types as dev dependencies #163

Merged
merged 1 commit into from
Apr 2, 2023
Merged

Suggest installing types as dev dependencies #163

merged 1 commit into from
Apr 2, 2023

Conversation

ccouzens
Copy link
Contributor

Typescript types are usually only required at build time, and not runtime. But the old instructions would end up with the types being around at run-time.

From the npm install documentation

npm install saves any specified packages into dependencies by default.

Checklist

  • I have ensured my pull request is not behind the main or master branch of the original repository.
  • I have rebased all commits where necessary so that reviewing this pull request can be done without having to merge it first.
  • I have written a commit message that passes commitlint linting.
  • I have ensured that my code changes pass linting tests.
  • I have ensured that my code changes pass unit tests.
  • I have described my pull request and the reasons for code changes along with context if necessary.

@ccouzens
Suggest installing types as dev dependencies
8b3f84b 
Typescript types are usually only required at build time, and not runtime.
But the old instructions would end up with the types being around at run-time.

From the [npm install documentation](https://docs.npmjs.com/cli/v6/commands/npm-install)

> `npm install` saves any specified packages into `dependencies` by default.
@3imed-jaberi 3imed-jaberi merged commit ae98680 into koajs:master Apr 2, 2023
@ccouzens ccouzens deleted the patch-1 branch April 3, 2023 19:33
@WontonSam WontonSam mentioned this pull request Jul 18, 2024
Open
This was referenced Sep 8, 2024
Open
Open
Open
Open
Open
Open
This was referenced Sep 16, 2024
Open
Open
@WontonSam WontonSam mentioned this pull request Sep 18, 2024
Open
This was referenced Sep 20, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@3imed-jaberi 3imed-jaberi 3imed-jaberi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ccouzens @3imed-jaberi