Skip to content

Commit 91f69cc

Browse files
authored
fix grammar after reading
1 parent 3353826 commit 91f69cc

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

EN/1_culture.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ MRI is the reference implementation of the Ruby language, so that approved Ruby
2626

2727
Ruby's primary repository uses Git for source control <https://www.ruby-lang.org/en/community/ruby-core/>. Some people have a right to modify this repository. We call them "Ruby committers". Now we have about 100 Ruby committers all over the world (but the number of active members is much smaller. If you become a Ruby committer, you can't throw away the title of "Ruby committer").
2828

29-
Committers can modify any of the source code of MRI. However, each committer has an area of responsibility. If a committer wants to modify another area, he/she is expected to ask and respect the advice of the responsible committers. For example, ko1 is a VM developer, so that if someone want to change the VM drastically, he wants to be consulted before any changes are committed.
29+
Committers can modify any of the source code of MRI. However, each committer has an area of responsibility. If a committer wants to modify another area, he/she is expected to ask and respect the advice of the responsible committers. For example, ko1 is a VM developer, so that if someone wants to change the VM drastically, he wants to be consulted before any changes are committed.
3030

3131
There is no formal code review system. We may check committed patches and point out issues that we notice. We use `git bisect` (or similar techniques) to investigate problems (e.g. bug reports). If we have a big change, we ask other committers for a review.
3232

@@ -63,7 +63,7 @@ Good bug reports should contain the following:
6363
For details, please check <https://bugs.ruby-lang.org/projects/ruby/wiki/HowToReport> (English)
6464
or Japanese version <https://bugs.ruby-lang.org/projects/ruby/wiki/HowToReportJ>.
6565

66-
Good feature request should contains the following:
66+
Good feature request should contain the following:
6767

6868
* Abstract (short summary)
6969
* Background (What is the issue you want to solve and why. Use-cases)
@@ -90,7 +90,7 @@ We also need to prepare a variety of environments to run our tests. For example,
9090
Usually we use Intel x86/64 CPU or ARM processors, but there are other processors that we try to test on.
9191
The list of Ruby's supported platforms can be found at: <https://bugs.ruby-lang.org/projects/ruby-trunk/wiki/SupportedPlatforms>.
9292

93-
Because MRI is used on many enviroments, it is preferable to run tests on as wide a variety of environments as possible.
93+
Because MRI is used in many enviroments, it is preferable to run tests on as wide a variety of environments as possible.
9494
It's common practice to use Continuous Integration (CI) to run automated tests. Ruby is no exception.
9595

9696
In addition to using the popular Travis-CI service, we also run the <http://rubyci.org> site to collect test results run on a wider variety of environments. Typically, a CI system uses its own computing resources. However, our resources are limited. So, instead of preparing and managing the computers for the multitude of environments we need, we gather the results from tests run by volunteers in the community who run tests on their own computing resources. The tool [chkbuild](https://github.com/ruby/chkbuild) builds Ruby, runs tests, generates results, and performs a diff on the output so that we can determine which versions of Ruby have particular bugs.
@@ -134,7 +134,7 @@ If you want to hack deeply into MRI, you need to know the C language.
134134

135135
### Communication channels
136136

137-
* Ruby's redmine: https://bugs.ruby-lang.org/projects/ruby/
137+
* Ruby's Redmine: https://bugs.ruby-lang.org/projects/ruby/
138138
* Ticket
139139
* Wiki
140140
* Mailing lists
@@ -156,7 +156,7 @@ If you want to hack deeply into MRI, you need to know the C language.
156156

157157
## Important note
158158

159-
This article introduces several rather pendantic "rules". However, what we interpreter developers value the most is "Hacking".
159+
This article introduces several rather pedantic "rules". However, what we interpreter developers value the most is "Hacking".
160160
If you contribute a great patch, we will support your contribution, even if you don't strictly abide by the above rules.
161161

162162
Write code, and have fun!

0 commit comments

Comments
 (0)