Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color in the format string is not propagated #806

Open
korken89 opened this issue Jan 17, 2024 · 2 comments
Open

Color in the format string is not propagated #806

korken89 opened this issue Jan 17, 2024 · 2 comments
Labels
type: bug Something isn't working

Comments

@korken89
Copy link

korken89 commented Jan 17, 2024

Hi,

I tried to add color to the format string for defmt_decoder in probe-rs to make it more readable, but the color specification on the string did not propagate properly.
Here is the testing PR in probe-rs: probe-rs/probe-rs#2063

This would help readability a lot. Is there someway to make this happen or does defmt_decoder need extension?

This also broke in probe-run v0.3.9 -> v0.3.10 where the file info part of the printing got the color wrong.

probe-run v0.3.9:
image

probe-run v0.3.10 and probe-rs run:
image

@andresovela
Copy link
Contributor

As mentioned in probe-rs/probe-rs#2063, I remember having the same issue when working with the ColoredString type and converting it to a normal String or &str. The desired functionality can be implemented using the format strings but we need a new defmt release for that to work.

@Urhengulas
Copy link
Member

There was a new release on 05.02.2024. Can you check if it works now?

@Urhengulas Urhengulas added the type: bug Something isn't working label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants