Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI step breaks on macos #445

Open
spookyvision opened this issue Apr 8, 2021 · 3 comments
Open

CI step breaks on macos #445

spookyvision opened this issue Apr 8, 2021 · 3 comments
Labels
difficulty: medium Somewhat difficult to solve priority: low Low priority for the Knurling team status: needs info Requires more information from the reporter to move forward type: bug Something isn't working

Comments

@spookyvision
Copy link
Contributor

spookyvision commented Apr 8, 2021

currently the mdbook job is commented out for macos in .github/workflows/ci.yml because it fails:

Run cargo xtask test-book
(...)
Error: ["book: \'mdbook test -L ../target/debug -L ../target/debug/deps\' did not finish successfully: Killed by signal 9"]
Error: Process completed with exit code 1.

I could not reproduce this error on my local macos installation. Initial suspicion was a timeout problem, but increasing the timeout did not fix it. Maybe other resource limits are being hit (memory?)

@spookyvision spookyvision added the priority: low Low priority for the Knurling team label Apr 8, 2021
@Urhengulas Urhengulas added difficulty: medium Somewhat difficult to solve status: needs info Requires more information from the reporter to move forward type: bug Something isn't working labels Apr 8, 2021
@justahero
Copy link
Contributor

The test-book command fails internally, because the environment variable CARGO_CRATE_NAME is not set for some reason, even though the env var is passed as an argument (see main.rs) to the run_command function. When assembling the process inside run_command the list of env vars is not set here on OSX.

Running the mdbook command directly including the env var works:

cd book
CARGO_CRATE_NAME=defmt mdbook test -L ../target/debug -L ../target/debug/deps

Using std::env::set_var instead of std::process::Command::envs does not work either. The spawned process will not pick up any env vars.

Tested with:

  • rustc 1.55.0
  • mdbook v0.4.13

(It seems this is not well supported on OSX, not sure how to fix this)

@spookyvision
Copy link
Contributor Author

I was definitely able to run mdbook tests on my macos installation. That's unfortunately all I can contribute currently. Ping me next week maybe…

@spookyvision
Copy link
Contributor Author

uh, yeah, as already noted in the issue description it works on my machine. I misread this as Johann writing it¿ Time to sleep

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty: medium Somewhat difficult to solve priority: low Low priority for the Knurling team status: needs info Requires more information from the reporter to move forward type: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants