fix: off-by-one: do not ignore the base block which matches the requested block

UdjinM6 · UdjinM6 · commit 9c98f997db62 · 2025-04-04T00:23:43.000+03:00
diff --git a/src/llmq/snapshot.cpp b/src/llmq/snapshot.cpp
@@ -399,7 +399,7 @@ uint256 GetLastBaseBlockHash(Span<const CBlockIndex*> baseBlockIndexes, const CB
     // default to genesis block
     uint256 hash{Params().GenesisBlock().GetHash()};
     for (const auto baseBlock : baseBlockIndexes) {
-        if (baseBlock->nHeight >= blockIndex->nHeight)
+        if (baseBlock->nHeight > blockIndex->nHeight)
             break;
         hash = baseBlock->GetBlockHash();
     }

Original file line number	Diff line number	Diff line change
`@@ -399,7 +399,7 @@ uint256 GetLastBaseBlockHash(Span<const CBlockIndex*> baseBlockIndexes, const CB`
`399`	`399`	`// default to genesis block`
`400`	`400`	`uint256 hash{Params().GenesisBlock().GetHash()};`
`401`	`401`	`for (const auto baseBlock : baseBlockIndexes) {`
`402`		`- if (baseBlock->nHeight >= blockIndex->nHeight)`
	`402`	`+ if (baseBlock->nHeight > blockIndex->nHeight)`
`403`	`403`	`break;`
`404`	`404`	`hash = baseBlock->GetBlockHash();`
`405`	`405`	`}`