Release artifact for Linux-arm64?

[BatmanAoD]

For...reasons, I need to build a multi-arch Docker image for Linux, supporting x86_64 and arm64. Knope releases include arm64 binaries for Mac OS, but not for arm64. Can arm64 binaries be added?

[dbanty]

Can you try out the new artifact on https://github.com/knope-dev/knope/releases/tag/knope/v0.22.3-rc.0 ? I had a few options for targets, that seemed the most portable.

[BatmanAoD]

Looks fine to me, thanks!

[BatmanAoD]

Okay, it turns out that cargo-binstall doesn't actually know how to find the Knope binaries, so it gets downloaded from quickinstall by default; and I guess quickinstall doesn't support arm64 Linux either.

The issue is the binstall only looks for tags { version } and v{ version }, but Knope uses knope/v{ version }: https://github.com/cargo-bins/cargo-binstall/blob/main/SUPPORT.md#for-github

If you push a v<version> tag on every release, Binstall should be able to find the artifacts automatically. But you could also just add this to the Knope CLI crate's Cargo.toml:

[package.metadata.binstall]
pkg-url = "{ repo }/releases/download/knope%2Fv{ version }/{ name }-{ target }{ archive-suffix }"

I've tested that by setting pkg-url explicitly as a command line flag for binstall, it is able to download the artifacts from the GitHub releases.

[dbanty]

Added that Cargo.toml bit for Knope 0.23.0 (releasing now). LMK if it works! I will probably also switch back to the top-level tag at some point but I want to build a Knope feature to make it easy in monorepos 😁

[BatmanAoD]

Nice, it works! Thanks!