Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for List Users endpoint #22

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

adamantike
Copy link
Contributor

This change adds the List method to UsersService.

Adding support for custom properties is pending, as the existing util relies on getting a raw string representation for the user, retrieved directly from the API.

This change adds the `List` method to `UsersService`.

Adding support for custom properties is pending, as the existing util
relies on getting a raw string representation for the user, retrieved
directly from the API.
@adamantike
Copy link
Contributor Author

@brentjanderson @cjbell, gentle ping, considering you have reviewed other PRs in this project.

Copy link
Contributor

@cjbell cjbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 thank you!

@cjbell cjbell merged commit 9acbc04 into knocklabs:main Oct 4, 2023
@adamantike adamantike deleted the feat/add-UsersList branch October 4, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants