Graphs #163
Merged
Graphs #163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashokdey
added
enhancement
|
@TheSTL can you look into this? I am requesting a review from @igauravsehrawat as well! |
TheSTL
reviewed
Apr 27, 2020
src/_DataStructures_/Set/index.js
Outdated
| } | ||
|
|
||
| union(givenSet) { | ||
| const result = new Set(); |
TheSTL
reviewed
Apr 27, 2020
| } | ||
|
|
||
| // eslint-disable-next-line no-bitwise | ||
| hashVal &= hashVal; |
There was a problem hiding this comment.
To get a better hash. It may look useless but here is the explanation: https://stackoverflow.com/questions/38356644/why-is-the-bitwise-and-of-two-of-the-same-value-producing-a-different-value
I must update it in the comments as well
TheSTL
reviewed
Apr 27, 2020
| @@ -36,12 +36,14 @@ class HashTable { | |||
| for (let i = 0; i < loopTill; i += 1) { | |||
| const char = stringKey[i]; | |||
| const value = char.charCodeAt(0) - 96; | |||
| index = (index * PRIME_MULTIPLIER + value) % this.bucket.length; | |||
| // eslint-disable-next-line no-bitwise | |||
| index &= index; | |||
TheSTL
reviewed
Apr 27, 2020
| hashVal += PRIME_ADDER; | ||
| } | ||
| // eslint-disable-next-line no-bitwise | ||
| hashVal &= hashVal; |
TheSTL
approved these changes
Apr 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🕸 What's Inside?
A simple implementation of Graphs using the Adjacency List using Singly Linked List and Object
Having the following APIs:
Changes: