Skip to content

Add a config flag to use service name in traces #15822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

pomyslowynick
Copy link

Proposed Changes

  • Use a flag to use ServingServiceas the trace service.name which is added in this PR

Motivation is pretty much the same as in the other PR, copy pasting:

While the OTel migration is in progress it would be very helpful to have a flag which allows users toggling the ServingService to be used as the service.name in traces.
This is related to #12969 and would still be relevant after the migration to OTel.

Release Note

You can now use the `useServingService` flag in the tracing config to use the `ServingService` as the `service.name` in traces. Current default is to use the `ServingPod` as the `service.name`, and it remains the same if the flag is not set.

Copy link

linux-foundation-easycla bot commented Mar 31, 2025

CLA Signed

  • ✅login: pomyslowynick / (3c021e5)

The committers listed above are authorized under a signed CLA.

@knative-prow knative-prow bot requested review from dprotaso and skonto March 31, 2025 10:26
Copy link

knative-prow bot commented Mar 31, 2025

Welcome @pomyslowynick! It looks like this is your first PR to knative/serving 🎉

@knative-prow knative-prow bot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 31, 2025
Copy link

knative-prow bot commented Mar 31, 2025

Hi @pomyslowynick. Thanks for your PR.

I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

knative-prow bot commented Mar 31, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pomyslowynick
Once this PR has been reviewed and has the lgtm label, please assign skonto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dprotaso dprotaso added this to the v1.19.0 milestone Apr 13, 2025
@dprotaso
Copy link
Member

/hold

Made a comment here - knative/pkg#3164 (comment)

I want to revisit our OTel approach after the next release. That might require breaking changes and we'd probably make this change without a config map flag.

@knative-prow knative-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 13, 2025
@pomyslowynick
Copy link
Author

/hold

Made a comment here - knative/pkg#3164 (comment)

I want to revisit our OTel approach after the next release. That might require breaking changes and we'd probably make this change without a config map flag.

Happy to help with OTel migration if that brings us closer to resolving this issue, if there's a need.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants