Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move DomainMapping from Beta to GA #13967

Open
1 of 5 tasks
nak3 opened this issue May 9, 2023 · 10 comments
Open
1 of 5 tasks

Move DomainMapping from Beta to GA #13967

nak3 opened this issue May 9, 2023 · 10 comments
Labels
area/API API objects and controllers area/networking good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Well-understood/specified features, ready for coding. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Milestone
Icebox

Comments

@nak3
Copy link
Contributor

nak3 commented May 9, 2023 •
edited by dprotaso
Loading

DomainMapping became Beta since Knative v0.24 and now it should be enough to move GA.

To make it GA:

  • Drop v1alpha1 DomainMapping API
  • Add v1 DomainMapping API
  • Remove betaTests configuration from e2e in serving and networking repos.

Follow up tasks after GA:

  • Merge DomainMapping's controller and webhook into serving controller and webhook.
  • Drop v1beta1 DomainMapping API.

/area API
/area networking
/kind good-first-issue
@nak3 nak3 added the kind/feature Well-understood/specified features, ready for coding. label May 9, 2023
@knative-prow knative-prow bot added area/API API objects and controllers area/networking kind/good-first-issue Denotes an issue ready for a new contributor. labels May 9, 2023
@nak3
Copy link
Contributor Author

nak3 commented May 9, 2023

/cc @dprotaso @evankanderson @psschwei @ReToCode @skonto

If there is any objection to make DomainMapping GA or miss some process, please leave a comment.

@nak3 nak3 mentioned this issue May 9, 2023
Closed
@nak3
Copy link
Contributor Author

nak3 commented May 10, 2023

Just in case. As per the attached feature track in #7748 , the requirement of the GA is:

Four releases have been cut since the Alpha milestone, no roadblocks have been discovered in any backend implementation that argue against long-term support.

It has already done more than 4 releases and no roadblocks have been discovered in any backend implementation that argue against long-term support.

@dprotaso
Copy link
Member

There's a project tracking this here - https://github.com/knative/serving/projects/47

It seems like folks have added some issues to the GA column since I last looked.

A big one for me is the fact that certain protocols don't seem to work out of the box - #13083

@nak3
Copy link
Contributor Author

nak3 commented May 12, 2023

Ah, okay. Then, the issues in GA column should be solved.

@github-actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2023
@xiangpingjiang
Copy link
Contributor

/assign

@ReToCode
Copy link
Member

/remove-lifecycle stale

@knative-prow knative-prow bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 11, 2023
@xiangpingjiang xiangpingjiang mentioned this issue Aug 11, 2023
Closed
@xiangpingjiang xiangpingjiang removed their assignment Aug 19, 2023
@Priyansurout
Copy link
Contributor

/assign

@dprotaso dprotaso added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. and removed kind/good-first-issue Denotes an issue ready for a new contributor. labels Nov 23, 2023
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@dprotaso
Copy link
Member

/unassign @Priyansurout
/lifecycle frozen

@knative-prow knative-prow bot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 22, 2024
@dprotaso dprotaso added this to the Icebox milestone Feb 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/API API objects and controllers area/networking good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/feature Well-understood/specified features, ready for coding. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Milestone
Icebox
Development

Successfully merging a pull request may close this issue.

Domain mapping from beta to ga xiangpingjiang/serving
5 participants
@dprotaso @nak3 @ReToCode @xiangpingjiang @Priyansurout