Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webhook binding labels should be more finely grained #1233

Open
lberk opened this issue Apr 21, 2020 · 2 comments
Open

webhook binding labels should be more finely grained #1233

lberk opened this issue Apr 21, 2020 · 2 comments
Labels
area/API kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@lberk
Copy link
Member

lberk commented Apr 21, 2020

As @mattmoor described in #1208, we face a growing number of bindings.

I'd left a TODO about adding per-Binding opt-in/out, so I wonder if we're going to go this route whether we should be doing so using a fine-grained annotation like that instead.. WDYT?

Could be something like: {gvr}/binding: enabled? so:

sinkbindings.sources.knative.dev/binding: "enabled"
githubbindings.bindings.knative.dev/binding: "enabled"
vspherebindings.sources.tanzu.vmware.com: "enabled"
...

the webhook should implement this

@github-actions
Copy link
Contributor

This issue is stale because it has been open for 90 days with no
activity. It will automatically close after 30 more days of
inactivity. Reopen the issue with /reopen. Mark the issue as
fresh by adding the comment /remove-lifecycle stale.

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Aug 24, 2020
@mattmoor
Copy link
Member

/lifecycle frozen

@knative-prow-robot knative-prow-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API kind/feature lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

3 participants