Skip to content

🚧 [WIP] 🚧 Generate GitHub actions workflow. 👷 🏗️ #3128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

🚧 [WIP] 🚧 Generate GitHub actions workflow. 👷 🏗️ #3128

wants to merge 17 commits into from
+16,114 −14,721

Conversation

@twoGiants
Copy link

@twoGiants twoGiants commented Oct 22, 2025

Changes

  • 🎁 tba ...
  • 🧹 tba ...

/kind enhancement

Fixes #tba...

Release Note

Docs

@knative-prow
Copy link

knative-prow bot commented Oct 22, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@knative-prow knative-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement labels Oct 22, 2025
@knative-prow knative-prow bot requested review from jrangelramos and nainaz October 22, 2025 12:26
@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 22, 2025
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 22, 2025
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch 2 times, most recently from edad0e7 to 2b2cc43 Compare October 24, 2025 16:48
@knative-prow knative-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2025
@twoGiants
chores: add test artifacts to gitignore
c71b57e 
Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from 48ac762 to c2000cd Compare November 7, 2025 12:16
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2025
@codecov
Copy link

codecov bot commented Nov 7, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 73.85621% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.00%. Comparing base (8f447a8) to head (4dd59ad).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
cmd/ci/workflow.go 81.25% 6 Missing and 6 partials ⚠️
cmd/testing/factory.go 0.00% 12 Missing ⚠️
cmd/ci/config.go 60.00% 10 Missing ⚠️
cmd/config.go 50.00% 3 Missing ⚠️
cmd/config_ci.go 92.59% 1 Missing and 1 partial ⚠️
cmd/config_volumes.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #3128      +/-   ##
==========================================
+ Coverage   62.85%   64.00%   +1.14%     
==========================================
  Files         148      155       +7     
  Lines       13202    13339     +137     
==========================================
+ Hits         8298     8537     +239     
+ Misses       3941     3809     -132     
- Partials      963      993      +30
Flag Coverage Δ
e2e-tests 42.80% <31.20%> (+1.32%) ⬆️
integration-tests 58.42% <62.74%> (+1.84%) ⬆️
unit-tests 50.36% <62.74%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 12, 2025
@knative-prow-robot
Copy link

knative-prow-robot commented Nov 12, 2025

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow
Copy link

knative-prow bot commented Nov 25, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: twoGiants
Once this PR has been reviewed and has the lgtm label, please assign matejvasek for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@twoGiants
chores: fix typos
1481ce0 
Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: add config ci command and refactor interfaces
a0d16f8 
Add 'func config ci' command as foundation for GitHub Actions
workflow generation. Extract function loader/saver interfaces
into cmd/common package and create cmd/testing factory for
reusable test helpers.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: add claude project configuration
b8787a1 
Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: generate github workflow file in config ci
43f998f 
Add functionality to create GitHub Actions workflow directory and file
when running config ci command. Includes CIConfig struct for managing
workflow paths and permissions, with comprehensive test coverage.

Also fixes typo and refactors config tests to use helper functions.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: tell claude to show commit msg
0803cfe 
Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: generate github workflow for remote build
42637f0 
- Add YAML structure types for workflow generation
- Generate hard coded remote-build-and-deploy workflow with checkout,
  func cli setup, and deploy steps
- Validate workflow structure and content in tests
- Export NewCIConfig for external use

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
refactor: extract ci logic into dedicated package
18884c1 
- Move CIConfig and workflow structs to cmd/ci package
- Separate config management (config.go) and workflow generation
  (workflow.go)
- Add CIConfig methods for path resolution
- Support custom workflow names via NewDefaultCIConfigWithName
- Update imports across cmd package

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: update project guidelines and docs
25c54ea 
- Add TDD and implementation guidelines to CLAUDE.md
- Create /creview slash command for code reviews
- Update issue-744 feature doc to mark Phase 2.1 complete

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: regenerate fs
9d26d0b 
Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
refactor: streamline workflow persistence
843adc0 
- Add NewGithubWorkflowFromPath for loading workflows from disk
- Replace AsYaml + PersistToDisk with Persist method that handles both
  marshalling and file operations
- Rename FnGithubWorkflowYamlPath to FnGithubWorkflowFilepath
- Extract test assertion logic into helper functions
- Improve test readability with consistent naming and structure

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: add k8s context and registry auth
d4f77c4 
- Add Kubernetes context setup using azure/k8s-set-context action with
  configurable kubeconfig secret key
- Add optional container registry authentication with conditional execution
- Support self-hosted runners configuration
- Number workflow steps for better readability

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: add configurable registry authentication
34f48a0 
Enable optional registry authentication in CI workflows to support
both secure and insecure registry scenarios. Add configuration for
custom registry secret keys.

Introduce CIConfigBuilder for flexible configuration in tests.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: document deployment workflows
fa359d2 
Add comprehensive memory files documenting deployment to local
kind clusters and remote OpenShift environments, covering auth
flows, registry config, Tekton setup, and GitHub Actions.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
feat: add local build workflow and debug options
3c535e2 
Adds support for local, remote workflow generation and debug
configuration via command-line flags.

Workflow name and registry login can be configured via flags
too. Debug mode adds workflow_dispatch trigger and func CLI
caching for rapid iterations on workflow runs.

Config creation refactored to use cobra flags.

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
refactor: move ci config to command flags
0c8e7ee 
Replaces pre-built CIConfig objects with command-line flags for
more flexible configuration and realistic testing.

- Add --remote, --debug, --self-hosted-runner flags
- Update tests to use flag parsing
- Set workflow name based on --remote flag

Issue SRVOCF-744

Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants
chores: update claude memory
b1b2f23 
Signed-off-by: Stanislav Jakuschevskij <sjakusch@redhat.com>
@twoGiants twoGiants force-pushed the issue-744-generate-github-actions-workflow branch from eda3019 to b1b2f23 Compare November 25, 2025 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jrangelramos jrangelramos Awaiting requested review from jrangelramos

@nainaz nainaz Awaiting requested review from nainaz

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@twoGiants @knative-prow-robot