Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SinkBinding matching a subject using labels doesn't update the subject when label is removed #5835

Open
xtreme-sameer-vohra opened this issue Oct 20, 2021 · 0 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)
Milestone

Comments

@xtreme-sameer-vohra
Copy link
Contributor

Describe the bug
When a SinkBinding is created with a subject using labels

kn source binding create bind-event-display --subject Service:serving.knative.dev/v1:foo=bar --sink ksvc:event-display

The binding injects expected variables like K_SINK into a Knative Service such as

kn service create hello --image SOME_IMAGE -l foo=bar

When the service is updated to remove the label

kn service update hello  -l foo-

The binding injected variables are still present in the Knative Service

kubectl describe ksvc/hello
.
..
    Spec:
      Container Concurrency:  0
      Containers:
        Env:
          Name:   TARGET
          Value:  World
          Name:   K_SINK
          Value:  http://event-display.default.svc.cluster.local
          Name:   K_CE_OVERRIDES
        Image:    gcr.io/knative-samples/helloworld-go@sha256:5ea96ba4b872685ff4ddb5cd8d1a97ec18c18fae79ee8df0d29f446c5efe5f50
        Name:     user-container

Expected behavior
The binding injected variables are removed when a subject's matching label is no longer present

To Reproduce
See steps above
Knative release version
v0.26.0

@xtreme-sameer-vohra xtreme-sameer-vohra added the kind/bug Categorizes issue or PR as related to a bug. label Oct 20, 2021
@devguyio devguyio added the triage/accepted Issues which should be fixed (post-triage) label Dec 15, 2021
@devguyio devguyio moved this to Ready To Work in Eventing WG Roadmap Dec 15, 2021
@devguyio devguyio moved this from Ready To Work to In Design in Eventing WG Roadmap Dec 15, 2021
@devguyio devguyio added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Dec 15, 2021
@devguyio devguyio added this to the Backlog milestone Jan 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. triage/accepted Issues which should be fixed (post-triage)
Projects
None yet
Development

No branches or pull requests

2 participants