Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify logging behaviour to be consistent with serving repo #274

Closed
vaikas opened this issue Jul 24, 2018 · 2 comments
Closed

Unify logging behaviour to be consistent with serving repo #274

vaikas opened this issue Jul 24, 2018 · 2 comments
Milestone
v0.5.0

Comments

@vaikas
Copy link
Contributor

vaikas commented Jul 24, 2018

Expected Behavior

logging should be consistent between our repos, and much work went into unifying them in the serving repo to use context and not using glog. So we should do the same

Actual Behavior

much usage of glog in the eventing repo.
context is not passed around.
@vaikas
Copy link
Contributor Author

vaikas commented Jul 24, 2018

More context at:
knative/serving#347

@n3wscott
Copy link
Contributor

I can start looking at this.

@n3wscott n3wscott mentioned this issue Jul 25, 2018
Closed
@scothis scothis mentioned this issue Aug 23, 2018
Closed
@vaikas vaikas added this to the v0.4.0 milestone Jan 4, 2019
@vaikas vaikas modified the milestones: v0.4.0, v0.5.0 Mar 6, 2019
This was referenced Mar 8, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5.0
Development

No branches or pull requests
2 participants
@vaikas @n3wscott