Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add event message verification to cronjob e2e test #698

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion test/e2e/cli.go
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ type KnRunResult struct {
ErrorExpected bool
}

// RunKubectl runs "kk" in a given namespace
// RunKn runs "kn" in a given namespace
func RunKn(namespace string, args []string) KnRunResult {
if namespace != "" {
args = append(args, "--namespace", namespace)
Expand All @@ -185,6 +185,7 @@ func RunKubectl(namespace string, args ...string) (string, error) {
args = append(args, "--namespace", namespace)
}
stdout, stderr, err := runCli("kubectl", args)
//out := fmt.Sprintf("$kubectl %s \n %s", args, stdout)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Member Author

@daisy-ycguo daisy-ycguo Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debug purpose. will remove in the latest version.

if err != nil {
return stdout, errors.Wrap(err, fmt.Sprintf("stderr: %s", stderr))
}
Expand Down
1 change: 1 addition & 0 deletions test/e2e/common.go
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ import (

const (
KnDefaultTestImage string = "gcr.io/knative-samples/helloworld-go"
EventDisplayImage string = "gcr.io/knative-releases/github.com/knative/eventing-contrib/cmd/event_display"
MaxRetries int = 10
RetrySleepDuration time.Duration = 5 * time.Second
)
Expand Down
55 changes: 54 additions & 1 deletion test/e2e/cronjob_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,10 @@
package e2e

import (
"fmt"
"strings"
"testing"
"time"

"gotest.tools/assert"

Expand Down Expand Up @@ -56,7 +59,57 @@ func TestSourceCronJob(t *testing.T) {
jpSinkRefNameInSpec := "jsonpath={.spec.sink.ref.name}"
out, err := test.getResourceFieldsWithJSONPath("cronjobsource", "testcronjobsource2", jpSinkRefNameInSpec)
assert.NilError(t, err)
assert.Equal(t, out, "testsvc1")
//assert.Equal(t, out, "testsvc1")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daisy-ycguo with the latest commits, there is a conflict.

wrt/ the issue: I will open an issue on test-infrastructure so that the istio local gateway gets enabled for the tests.

Until test-infrastructure gets update, this PR will not pass the integration test.

assert.Check(t, util.ContainsAllIgnoreCase(out, "testsvc1"))

t.Log("verify event messages from cronjob source")
mymsg := "This is a message from cronjob."
test.serviceCreateEventDisplay(t, r, "displaysvc")
test.cronJobSourceCreate(t, r, "testcronjobsource3", "*/1 * * * *", mymsg, "svc:displaysvc")
results := test.kn.Run("source", "cronjob", "describe", "testcronjobsource3")
r.AssertNoError(results)
out, err = kubectl{test.kn.namespace}.Run("get", "pod", "-l", "sources.eventing.knative.dev/cronJobSource=testcronjobsource3", "-o", "yaml")
t.Log(out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary ? Maybe better assert on out.

Copy link
Member Author

@daisy-ycguo daisy-ycguo Mar 4, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debug purpose. will remove in the latest version.

err = test.verifyEventDisplayLogs(t, "displaysvc", "This is a message from cronjob")
assert.NilError(t, err)
}

func (test *e2eTest) verifyEventDisplayLogs(t *testing.T, svcname string, message string) error {
var (
retries int
err error
out string
)

selectorStr := fmt.Sprintf("serving.knative.dev/service=%s", svcname)
for retries < 5 {
out, err = kubectl{test.kn.namespace}.Run("logs", "-l", selectorStr, "-c", "user-container")
if err != nil {
t.Logf("error happens at kubectl logs -l %s -c -n %s: %v", selectorStr, test.kn.namespace, err)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you should return here with the error.

} else if err == nil && strings.Contains(out, message) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

err is nil for sure when you reach this (see condition before)

break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not return immediately ? then you don't have to check for nrRetries after the loop.

} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can remove the else if you return early

t.Logf("return from kubectl logs -l %s -n %s: %s", selectorStr, test.kn.namespace, out)
out, err = kubectl{test.kn.namespace}.Run("get", "pods")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if err ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debug purpose. will remove in the latest version.

t.Log(out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why log here ?

out, err = kubectl{test.kn.namespace}.Run("logs", "-l", "sources.eventing.knative.dev/cronJobSource=testcronjobsource3")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if err ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debug purpose. will remove in the latest version.

t.Log(out)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why log ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for debug purpose. will remove in the latest version.

}
retries++
time.Sleep(2 * time.Minute)
}

if retries == 5 {
return fmt.Errorf("Expected log incorrect after retry 5 times. Expecting to include:\n%s\n Instead found:\n%s\n", message, out)
} else {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

else not needed

return nil
}
}

func (test *e2eTest) serviceCreateEventDisplay(t *testing.T, r *KnRunResultCollector, serviceName string) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this not a public Test... function?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's same as serviceCreate function defined in service_test.go

func (test *e2eTest) serviceCreateDuplicate(t *testing.T, r *KnRunResultCollector, serviceName string)

Although it's not public, but you can use this function under any e2e tests.

out := test.kn.Run("service", "create", serviceName, "--image", EventDisplayImage)
r.AssertNoError(out)
assert.Check(t, util.ContainsAllIgnoreCase(out.Stdout, "service", serviceName, "creating", "namespace", test.kn.namespace, "ready"))
}

func (test *e2eTest) cronJobSourceCreate(t *testing.T, r *KnRunResultCollector, sourceName string, schedule string, data string, sink string) {
Expand Down