feat: remove yaml merge tag

[converge]

Fixes #

Merge keys are not officially supported in YAML according to its specifications. These keys are associated with an older version of YAML (1.1), which is now considered obsolete. Additionally, these merge keys haven't been updated or included in the current YAML version (1.2), so there's no guarantee that they will function as expected or be supported. In summary, using merge keys in YAML might not work reliably and is not recommended due to these limitations and lack of support in the latest YAML version.

I attempted to install the YAML mentioned using Kustomize, but the installation failed because Kustomize couldn't properly interpret or render the YAML file.

Proposed Changes

• I suggest that we avoid utilizing merge tags to ensure compliance with YAML specifications, particularly in the latest versions like 1.2.x.

[knative-prow]

Hi @converge. Thanks for your PR.

I'm waiting for a knative-extensions member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[knative-prow]

Welcome @converge! It looks like this is your first PR to knative-extensions/eventing-kafka-broker 🎉

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (02a879b) 61.99% compared to head (2440de3) 62.19%.
Report is 6 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #3654      +/-   ##
============================================
+ Coverage     61.99%   62.19%   +0.19%     
- Complexity      845      846       +1     
============================================
  Files           188      188              
  Lines         12634    12690      +56     
  Branches        273      273              
============================================
+ Hits           7833     7892      +59     
+ Misses         4187     4185       -2     
+ Partials        614      613       -1     

Flag	Coverage Δ
java-unittests	74.49% <ø> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[matzew]

we do use these in eventing core as well

[converge]

we do use these in eventing core as well

do you mean custom tag? that's true, only the source is different. in eventing-core, it comes from eventing-core.yaml and the mentioned tag comes from https://github.com/knative-extensions/eventing-kafka-broker/blob/main/control-plane/config/eventing-kafka-broker/200-webhook/500-webhook.yaml#L103

[matzew]

I think at general knative level we use these. Not just here
/cc @dprotaso

[dprotaso]

We dropped these in serving since we only have one version - so we don't have any usage there

[matzew]

/ok-to-test

/lgtm
/approve

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: converge, matzew

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [matzew]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[matzew]

Thanks for the PR, @converge

[pierDipi]

/test upgrade-tests

[Cali0707]

/cherry-pick release-1.13

[knative-prow-robot]

@Cali0707: new pull request created: #3679

In response to this:

/cherry-pick release-1.13

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.