Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve subscriber disabled status to respective label #1793

Closed
CodeShakingSheep opened this issue Mar 23, 2024 · 3 comments
Closed

Resolve subscriber disabled status to respective label #1793

CodeShakingSheep opened this issue Mar 23, 2024 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@CodeShakingSheep
Copy link

Version:

  • listmonk: 3.0.0
  • OS: Ubuntu

Description of the bug and steps to reproduce:
Hi,
and first of all thanks for listmonk. I'm still testing it to use it in production soon. Until now it seems really fast and stable. :)
I just encountered one minor UI issue. Instead of showing a disabled label like "Disabled" for disabled subscribers the UI shows, I suppose, a label id subscribers.status.disabled, see screenshot.

Screenshots:
image

@CodeShakingSheep CodeShakingSheep added the bug Something isn't working label Mar 23, 2024
@MaximilianKohler
Copy link
Contributor

That's odd. It doesn't even appear to be in the code? https://github.com/search?q=repo%3Aknadh%2Flistmonk+subscribers.status.disabled&type=code - 0 results.

@knadh knadh added minor-bug and removed bug Something isn't working labels Mar 25, 2024
@knadh
Copy link
Owner

knadh commented Mar 25, 2024

Ah, this is from the obsolete disabled status from a very early version. It's not used anywhere anymore and subscribers are blocklisted instead of disabled.

Did you set this status via the API as it's not available on the UI.

@CodeShakingSheep
Copy link
Author

Yes, I set the status via API as "disabled" is still listed in the API docs, e.g. see here https://listmonk.app/docs/apis/subscribers/#post-apisubscribers

So, I would propose to update API docs and also make the API reject this status. What do you think?

@knadh knadh closed this as completed in d5cfaa9 Apr 1, 2024
@knadh knadh added documentation Improvements or additions to documentation and removed minor-bug labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants