Skip to content

Commit bc10d36

Browse files
committed
ulimit: change from RSS to virtual size
For some reason the max-RSS limit doesn't seem to be kicking in. Switch to putting a limit on the virtual size instead, and bump the limit from 500MB to 1.5GB.
1 parent 4a8040c commit bc10d36

File tree

1 file changed

+9
-9
lines changed

1 file changed

+9
-9
lines changed

Makefile

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ GTEST_DIR := $(DEPS_DIR)/gtest-1.7.0
3131

3232
USE_DEBUG_LIBUNWIND := 0
3333

34-
MAX_MEM_KB := 500000
35-
MAX_DBG_MEM_KB := 500000
34+
MAX_MEM_KB := 1500000
35+
MAX_DBG_MEM_KB := 1500000
3636

3737
TEST_THREADS := 1
3838

@@ -411,10 +411,10 @@ $1_unittest:
411411
$(NINJA) -C $(CMAKE_DIR_DBG) $1_unittest $(NINJAFLAGS)
412412
ln -sf $(CMAKE_DIR_DBG)/$1_unittest .
413413
dbg_$1_unittests: $1_unittest
414-
zsh -c 'ulimit -m $(MAX_MEM_KB); time $(GDB) $(GDB_CMDS) --args ./$1_unittest --gtest_break_on_failure $(ARGS)'
414+
zsh -c 'ulimit -v $(MAX_MEM_KB); time $(GDB) $(GDB_CMDS) --args ./$1_unittest --gtest_break_on_failure $(ARGS)'
415415
unittests:: $1_unittest
416416
run_$1_unittests: $1_unittest
417-
zsh -c 'ulimit -m $(MAX_MEM_KB); time ./$1_unittest $(ARGS)'
417+
zsh -c 'ulimit -v $(MAX_MEM_KB); time ./$1_unittest $(ARGS)'
418418
run_unittests:: run_$1_unittests
419419
)
420420
endef
@@ -770,12 +770,12 @@ check$1 test$1: $(PYTHON_EXE_DEPS) pyston$1
770770
run$1: pyston$1 $$(RUN_DEPS)
771771
PYTHONPATH=test/test_extension:$${PYTHONPATH} ./pyston$1 $$(ARGS)
772772
dbg$1: pyston$1 $$(RUN_DEPS)
773-
PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -m $$(MAX_DBG_MEM_KB); $$(GDB) $$(GDB_CMDS) --args ./pyston$1 $$(ARGS)'
773+
PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -v $$(MAX_DBG_MEM_KB); $$(GDB) $$(GDB_CMDS) --args ./pyston$1 $$(ARGS)'
774774
nosearch_run$1_%: %.py pyston$1 $$(RUN_DEPS)
775-
$(VERB) PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -m $$(MAX_MEM_KB); time ./pyston$1 $$(ARGS) $$<'
775+
$(VERB) PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -v $$(MAX_MEM_KB); time ./pyston$1 $$(ARGS) $$<'
776776
$$(call make_search,run$1_%)
777777
nosearch_dbg$1_%: %.py pyston$1 $$(RUN_DEPS)
778-
$(VERB) PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -m $$(MAX_DBG_MEM_KB); $$(GDB) $$(GDB_CMDS) --args ./pyston$1 $$(ARGS) $$<'
778+
$(VERB) PYTHONPATH=test/test_extension:$${PYTHONPATH} zsh -c 'ulimit -v $$(MAX_DBG_MEM_KB); $$(GDB) $$(GDB_CMDS) --args ./pyston$1 $$(ARGS) $$<'
779779
$$(call make_search,dbg$1_%)
780780
781781
ifneq ($$(ENABLE_VALGRIND),0)
@@ -905,7 +905,7 @@ opreportcg:
905905

906906
.PHONY: watch_% watch wdbg_%
907907
watch_%:
908-
@ ( ulimit -t 60; ulimit -m $(MAK_MEM_KB); \
908+
@ ( ulimit -t 60; ulimit -v $(MAK_MEM_KB); \
909909
TARGET=$(dir $@)$(patsubst watch_%,%,$(notdir $@)); \
910910
clear; $(MAKE) $$TARGET $(WATCH_ARGS); true; \
911911
while inotifywait -q -e modify -e attrib -e move -e move_self -e create -e delete -e delete_self \
@@ -953,7 +953,7 @@ test_cpp_ll:
953953
.PHONY: bench_exceptions
954954
bench_exceptions:
955955
$(CLANGPP_EXE) $(TEST_DIR)/bench_exceptions.cpp -o bench_exceptions -O3 -std=c++11
956-
zsh -c 'ulimit -m $(MAX_MEM_KB); time ./bench_exceptions'
956+
zsh -c 'ulimit -v $(MAX_MEM_KB); time ./bench_exceptions'
957957
rm bench_exceptions
958958

959959
TEST_EXT_MODULE_NAMES := basic_test descr_test slots_test type_test api_test

0 commit comments

Comments
 (0)