Upgrade to rustc 1.30-nightly (2018-08-30) #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The object file in the rlib has been renamed again, and the name now includes now gibberish. The assembly now has an extra instruction due to rust-lang/rust#45920 which increases the executable size with two bytes. (There doesn't appear to be a way to disable the unreachable() trap.)
Still requires nightly because sc uses inline_asm Also remove identity transmute left over from 8c711fc.
Switch sc repo to one with updated feature flags.
rustc/LLVM does constant propagation through the inline assembly and finds more compact instructions!
tormol
force-pushed
the
master
branch
4 times, most recently
from
e0405bb to
ecd4891
Compare
The changes in the fork I was using have now been merged and released.
* Update sc to 2.3.7 which uses asm!() instead of the removed llvm_asm!(). * Rename .cargo/config to avoid warning. * Update version in build.sh and output in README.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based on the other PR which upgraded to 1.16.
The executable has grown by two-bytes due to rust-lang/rust/pull/45920.
(PRs from deleted branches can be downloaded with
git fetch origin pull/1/head && git checkout -b pr-1 FETCH_HEAD)