Compiler flag to specify line ending microsoft#1693 code review adjustments

Author: kmashint

src/compiler/commandLineParser.ts

@@ -68,7 +68,7 @@ module ts {
         },
         {
             name: "newLine",
-            type: { "crlf": NewLineKind.CRLF, "lf": NewLineKind.LF },
+            type: { "crlf": NewLineKind.CarriageReturnLineFeed, "lf": NewLineKind.LineFeed },
             description: Diagnostics.Emit_newline_Colon_CRLF_dos_or_LF_unix,
             paramType: Diagnostics.NEWLINE,
             error: Diagnostics.Argument_for_newLine_option_must_be_CRLF_or_LF

src/compiler/diagnosticMessages.json

@@ -2006,7 +2006,7 @@
         "category": "Message", 
         "code": 6062
     },
-    "Argument for --newLine option must be 'CRLF' or 'LF'.": {
+    "Argument for 'newLine' option must be 'CRLF' or 'LF'.": {
         "category": "Error", 
         "code": 6063
     },

src/compiler/program.ts

@@ -91,8 +91,11 @@ module ts {
             }
         }
 
-        let newLine = [sys.newLine, "\r\n", "\n"][options.newLine ? Number(options.newLine) : 0];
-		
+        let newLine = 
+            options.newLine === NewLineKind.CarriageReturnLineFeed ? "\r\n" :
+            options.newLine === NewLineKind.LineFeed ? "\n" :
+            sys.newLine;
+
         return {
             getSourceFile,
             getDefaultLibFileName: options => combinePaths(getDirectoryPath(normalizePath(sys.getExecutingFilePath())), getDefaultLibFileName(options)),

src/compiler/types.ts

@@ -1691,9 +1691,8 @@ module ts {
     }
 
     export const enum NewLineKind {
-        DEFAULT = 0,
-        CRLF = 1,
-        LF = 2,
+        CarriageReturnLineFeed = 0,
+        LineFeed = 1,
     }
 
     export interface LineAndCharacter {