Skip to content

Commit baa186e

Browse files
committed
refactor(web-devtools): remove-arbitrator-ruler-check
1 parent f360928 commit baa186e

File tree

4 files changed

+7
-12
lines changed

4 files changed

+7
-12
lines changed

web-devtools/src/app/(main)/ruler/ChangeDeveloper.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const StyledLabel = styled.label`
3333
`;
3434

3535
const ChangeDeveloper: React.FC = () => {
36-
const { arbitrable, currentDeveloper, refetchData, isRulerOfArbitrable } = useRulerContext();
36+
const { arbitrable, currentDeveloper, refetchData } = useRulerContext();
3737
const [newDeveloper, setNewDeveloper] = useState("");
3838
const [isChanging, setIsChanging] = useState(false);
3939
const publicClient = usePublicClient();
@@ -46,7 +46,7 @@ const ChangeDeveloper: React.FC = () => {
4646
isError,
4747
} = useSimulateKlerosCoreRulerChangeRuler({
4848
query: {
49-
enabled: !isUndefined(arbitrable) && !isUndefined(newDeveloper) && isRulerOfArbitrable && isAddress(newDeveloper),
49+
enabled: !isUndefined(arbitrable) && !isUndefined(newDeveloper) && isAddress(newDeveloper),
5050
},
5151
args: [(arbitrable ?? "") as Address, newDeveloper as Address],
5252
});
@@ -77,7 +77,7 @@ const ChangeDeveloper: React.FC = () => {
7777
text="Update"
7878
onClick={handleClick}
7979
isLoading={isLoading || isChanging}
80-
disabled={isError || isLoading || isChanging || isUndefined(arbitrable) || !isRulerOfArbitrable || !isValid}
80+
disabled={!changeRulerConfig || isError || isLoading || isChanging || isUndefined(arbitrable) || !isValid}
8181
/>
8282
</Container>
8383
);

web-devtools/src/app/(main)/ruler/ManualRuling.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,7 @@ const ManualRuling: React.FC = () => {
116116
text="Rule"
117117
onClick={handleRuling}
118118
isLoading={isLoadingExecuteConfig || isSending}
119-
disabled={isDisabled || isError || isSending}
119+
disabled={isDisabled || isError || isSending || isLoadingExecuteConfig}
120120
/>
121121
</Container>
122122
);

web-devtools/src/app/(main)/ruler/RulingModes.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ const AutomaticPresetInputsContainer = styled.div`
4545
`;
4646

4747
const RulingModes: React.FC = () => {
48-
const { arbitrable, arbitrableSettings, isRulerOfArbitrable } = useRulerContext();
48+
const { arbitrable, arbitrableSettings } = useRulerContext();
4949
const [rulingMode, setRulingMode] = useState<RULING_MODE>();
5050
const [tie, setTie] = useState(false);
5151
const [overriden, setOverriden] = useState(false);
@@ -116,7 +116,7 @@ const RulingModes: React.FC = () => {
116116
useWriteKlerosCoreRulerChangeRulingModeToAutomaticRandom();
117117

118118
const isDisabled = useMemo(() => {
119-
if (!arbitrable || !isRulerOfArbitrable) return true;
119+
if (!arbitrable) return true;
120120
switch (rulingMode) {
121121
case RULING_MODE.Manual:
122122
return (
@@ -155,7 +155,6 @@ const RulingModes: React.FC = () => {
155155
isLoadingManualConfig,
156156
isLoadingAutomaticRandomConfig,
157157
isLoadingAutomaticPresetConfig,
158-
isRulerOfArbitrable,
159158
arbitrableSettings,
160159
tie,
161160
overriden,

web-devtools/src/context/RulerContext.tsx

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ interface IRulerContext {
2121
setArbitrable: (arbitrable: Address) => void;
2222
arbitrableSettings?: ArbitrableSettings;
2323
currentDeveloper?: Address;
24-
isRulerOfArbitrable: boolean;
2524
refetchData: () => void;
2625
}
2726
const RulerContext = createContext<IRulerContext | undefined>(undefined);
@@ -62,8 +61,6 @@ const RulerContextProvider: React.FC<{ children: React.ReactNode }> = ({ childre
6261
refetchDeveloper();
6362
}, [refetchArbitrableSettings, refetchDeveloper]);
6463

65-
const isRulerOfArbitrable = useMemo(() => address === currentDeveloper, [address, currentDeveloper]);
66-
6764
return (
6865
<RulerContext.Provider
6966
value={useMemo(
@@ -73,9 +70,8 @@ const RulerContextProvider: React.FC<{ children: React.ReactNode }> = ({ childre
7370
arbitrableSettings,
7471
currentDeveloper,
7572
refetchData,
76-
isRulerOfArbitrable,
7773
}),
78-
[arbitrable, setArbitrable, arbitrableSettings, currentDeveloper, refetchData, isRulerOfArbitrable]
74+
[arbitrable, setArbitrable, arbitrableSettings, currentDeveloper, refetchData]
7975
)}
8076
>
8177
{children}

0 commit comments

Comments
 (0)