Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom token defies the purpose of TCR at the cost of added complexity (feature bloat) #61

Open
marsrobertson opened this issue Jan 6, 2020 · 1 comment
Labels
wontfix This will not be worked on

Comments

@marsrobertson
Copy link

image

So my opinion (genuine honest, authentic opinion) - rather than be happy because of a new feature, I was like "OH NO", it's a cost, maintenance, complexity...

@satello
Copy link
Contributor

satello commented Jan 7, 2020

I understand your concern, but because it is not possible for us to get all information for all tokens in a decentralized manner (see response to #64) we need to give the users the ability to override or add new tokens. Basic users will never need to touch this. The list of tokens in the T2CR is quite extensive and the vast majority do not have the unknown decimal places problem. This was a good catch all solution for those problems and for tokens not in the T2CR yet.

@satello satello added the wontfix This will not be worked on label Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants