zstd: Fix ignored crc #580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klauspost
force-pushed
the
fix-missing-crc-consume
branch
from
8e3eb92
to
f04a617
Compare
When `IgnoreChecksum(true)` was used, single threaded decodes would not consume CRC. Bonus: Remove crc build tag for fuzzing.
klauspost
force-pushed
the
fix-missing-crc-consume
branch
from
f04a617
to
3c12593
Compare
|
Oh, sorry for that. :( I'll try to add some unit tests to cover that case. BTW, we already used this feature and in a real workload not checking CRC gave us 1.25x speedup! (Yeah, at cost of data corruption in case of cosmic ray hit.) |
|
No worries. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
IgnoreChecksum(true)was used, single threaded decodes would not consume CRC.Bonus: Remove crc build tag for fuzzing.