Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zstd: Improve best compression #360

Merged
merged 2 commits into from
Apr 22, 2021
Merged

Conversation

klauspost
Copy link
Owner

@klauspost klauspost commented Apr 22, 2021

See if we can find a better match by checking where the current best ends.
Use that offset to see if we can find a better full match.

Before/after. Ignore speed, may not be comparable:

file    out     level   insize      outsize     millis  mb/s
gob-stream  zskp    4   1911399616  171537212   32113   56.76
gob-stream  zskp    4   1911399616  167273881   29337   62.13

enwik9  zskp    4   1000000000  276609671   44029   21.66
enwik9  zskp    4   1000000000  275241169   36430   26.18

github-june-2days-2019.json zskp    4   6273951764  512796117   97791   61.18
github-june-2days-2019.json zskp    4   6273951764  503314661   93811   63.78

nyc-taxi-data-10M.csv   zskp    4   3325605752  495986829   89368   35.49
nyc-taxi-data-10M.csv   zskp    4   3325605752  490907191   65939   48.10

See if we can find a better match by checking where the current best ends.
Use that offset to see if we can find a better full match.

Before/after. Ignore speed, may not be comparable:

```
gob-stream  zskp    4   1911399616  171537212   32113   56.76
gob-stream	zskp	4	1911399616	167273881	29337	62.13

enwik9  zskp    4   1000000000  276609671   44029   21.66
enwik9	zskp	4	1000000000	275241169	36430	26.18

github-june-2days-2019.json zskp    4   6273951764  512796117   97791   61.18
github-june-2days-2019.json	zskp	4	6273951764	503314661	93811	63.78

nyc-taxi-data-10M.csv   zskp    4   3325605752  495986829   89368   35.49
nyc-taxi-data-10M.csv	zskp	4	3325605752	490907191	65939	48.10
```
@klauspost klauspost changed the title Zstd improve best compression zstd: Improve best compression Apr 22, 2021
@klauspost klauspost merged commit 93b05d6 into master Apr 22, 2021
@klauspost klauspost deleted the zstd-improve-best-compression branch April 22, 2021 10:54
mostynb added a commit to mostynb/zstdpool-syncpool that referenced this pull request Apr 28, 2021
This includes the following zstd improvement since v1.12.1:

* Add helpers to compress/decompress zstd inside zip files
  klauspost/compress#363
* Improve best compression
  klauspost/compress#360
* Improve better compression
  klauspost/compress#364
* Improve compression with dictionaries too
  klauspost/compress#365
mostynb added a commit to mostynb/go-grpc-compression that referenced this pull request Apr 28, 2021
This includes the following zstd improvement since v1.12.1:

* Add helpers to compress/decompress zstd inside zip files
  klauspost/compress#363
* Improve best compression
  klauspost/compress#360
* Improve better compression
  klauspost/compress#364
* Improve compression with dictionaries too
  klauspost/compress#365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant