address review

Author: enitrat

pyproject.toml

@@ -152,6 +152,7 @@ markers = [
   "UniswapV2ERC20",
   "UniswapV2Factory",
   "EIP3074",
+  "RIP7212",
   "UniswapV2Router",
   "AccountContract",
   "Utils",

src/kakarot/precompiles/precompiles.cairo

@@ -58,18 +58,17 @@ namespace Precompiles {
         if (is_rollup_precompile_ != 0) {
             // Rollup precompiles start at address 0x100. The last ethereum precompile is at address 0x0a.
             // The offset is computed as relative to the last ethereum precompile.
-            tempvar offset = 1 + 3 * (
-                (LAST_ETHEREUM_PRECOMPILE_ADDRESS + 1) +
-                (evm_address - FIRST_ROLLUP_PRECOMPILE_ADDRESS)
+            tempvar index = (LAST_ETHEREUM_PRECOMPILE_ADDRESS + 1) + (
+                evm_address - FIRST_ROLLUP_PRECOMPILE_ADDRESS
             );
-            tempvar range_check_ptr = range_check_ptr;
         } else {
             // Compute the corresponding offset in the jump table:
             // count 1 for "next line" and 3 steps per precompile evm_address: call, precompile, ret
-            tempvar offset = 1 + 3 * evm_address;
-            tempvar range_check_ptr = range_check_ptr;
+            tempvar index = evm_address;
         }
 
+        tempvar offset = 1 + 3 * index;
+
         // Prepare arguments
         [ap] = syscall_ptr, ap++;
         [ap] = pedersen_ptr, ap++;

tests/end_to_end/RIP7212/test_rip_7212.py

@@ -14,20 +14,22 @@ async def p256_verify_invoker(deploy_contract, owner):
 
 
 @pytest.mark.asyncio(scope="package")
-@pytest.mark.EIP3074
-class TestEIP3074:
-    class TestEIP3074Integration:
-        async def test_should_execute_authorized_call(self, p256_verify_invoker, owner):
+@pytest.mark.RIP7212
+class TestRIP7212:
+    class TestRIP7212Integration:
+        async def test_should_verify_secp256r1_signature(
+            self, p256_verify_invoker, owner
+        ):
 
             # input data from <https://github.com/ulerdogan/go-ethereum/blob/75062a6998e4e3fbb4cdb623b8b02e79e7b8f965/core/vm/contracts_test.go#L401-L410>
             input_data = (
-                "4cee90eb86eaa050036147a12d49004b6b9c72bd725d39d4785011fe190f0b4d",
-                "a73bd4903f0ce3b639bbbf6e8e80d16931ff4bcf5993d58468e8fb19086e8cac",
-                "36dbcd03009df8c59286b162af3bd7fcc0450c9aa81be5d10d312af6c66b1d60",
-                "4aebd3099c618202fcfe16ae7770b0c49ab5eadf74b754204a3bb6060e44eff3",
-                "7618b065f9832de4ca6ca971a7a1adc826d0f7c00181a5fb2ddf79ae00b4e10e",
+                "4cee90eb86eaa050036147a12d49004b6b9c72bd725d39d4785011fe190f0b4d"
+                "a73bd4903f0ce3b639bbbf6e8e80d16931ff4bcf5993d58468e8fb19086e8cac"
+                "36dbcd03009df8c59286b162af3bd7fcc0450c9aa81be5d10d312af6c66b1d60"
+                "4aebd3099c618202fcfe16ae7770b0c49ab5eadf74b754204a3bb6060e44eff3"
+                "7618b065f9832de4ca6ca971a7a1adc826d0f7c00181a5fb2ddf79ae00b4e10e"
             )
-            msg_hash, r_, s_, x_, y_ = [["0x" + word for word in wrap(input_data, 64)]]
+            msg_hash, r_, s_, x_, y_ = ["0x" + word for word in wrap(input_data, 64)]
             is_valid = await p256_verify_invoker.p256verify(
                 msg_hash,
                 r_,