Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Multilingual Transcription Support to 'GetTranscript()' Function #318

Merged

Conversation

rizkypujiraharja
Copy link
Contributor

Description

feat(client.go): add support for specifying language when fetching transcript data
feat(transcript.go): add support for specifying language when fetching transcript data
test(transcript_test.go): add tests for fetching transcript in different languages
test(video_test.go): update test to fetch transcript in English and Indonesia

feel free to review my PR :)

Issues to fix

Please link issues this PR will fix: #317

Reminding

Something you can do before PR to reduce time to merge

  • run "make build" to build the code
  • run "make format" to reformat the code
  • run "make lint" if you are using unix system
  • run "make test-integration" to pass all tests

@rizkypujiraharja rizkypujiraharja changed the title Added Multilingual Transcription Support to 'GetTranscript()' Function Add Multilingual Transcription Support to 'GetTranscript()' Function Dec 30, 2023
@corny corny merged commit c38aa71 into kkdai:master Jan 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transcript only supports videos in English
2 participants