Closed
Description
The Android API for requesting runtime permission has the following signature:
void requestPermissions (Activity activity,
String[] permissions,
int requestCode)
Currently via our PythonActivity.java
class, we're providing:
public void requestNewPermission(String permission)
See https://github.com/kivy/python-for-android/blob/02519cc/pythonforandroid/bootstraps/sdl2/build/src/main/java/org/kivy/android/PythonActivity.java#L608
It would be great if our interface was also somewhat matching the official name/signature.
- official documentation ActivityCompat#requestPermissions()
- PR discussion Bump SDL2 to 2.0.9 & Add API >=23 runtime permissions API #1528 (comment)
This would be a non-breaking change since we can keep our current requestNewPermission()
method and just add the new requestPermissions()
one.
Metadata
Metadata
Assignees
Labels
No labels