Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: support degradation config for Kitex server #6

Closed
felix021 opened this issue May 9, 2024 · 1 comment · Fixed by #7
Closed

Proposal: support degradation config for Kitex server #6

felix021 opened this issue May 9, 2024 · 1 comment · Fixed by #7
Assignees

Comments

@felix021
Copy link
Contributor

felix021 commented May 9, 2024

Please help add "degradation" as a new type of service governance config to these extensions, instructing Kitex clients to drop the corresponding percentile of requests, which is helpful when the server is confronted with an overwhelming amount of traffic.

For example, the config value may be:

{
    "enabled": true,
    "percentage": 50
}

Meaning the server should drop 50% of the traffic.
The default value should be {"enabled": false} to avoid loss.

Note that Kitex provides a builtin ACL mechanism by client.WithACLRules, which is helpful to implement the degradation policy.

Please prepare a tech plan (lark doc) for this task, including the background, goal, your design details and any problems for discussion before proceeding to the coding phase.

@XiaoYi-byte
Copy link
Contributor

I want to try it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants