Skip to content

Change overall background color to match react components #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

twells46
Copy link
Contributor

Fixes #499. I simply changed the styling to make the background for html and body elements to match what all the react containers are using.

@navzam
Copy link
Member

navzam commented Mar 28, 2025

This may fix the problem visually, but I think elements flowing out of the body isn't great and could cause other problems later

@twells46
Copy link
Contributor Author

I see what you mean, I'll take another look and try to fix the actual problem.

@twells46
Copy link
Contributor Author

Fixed by using minHeight instead of height for Container and CardContainer and giving the menu cards a minHeight as well. This should be ready to go now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Background doesn't stretch to the bottom of pages
3 participants