Fix Resource __repr__ method #3
Conversation
killbill/account.py
Outdated
| def find_by_id(cls, account_id, **options): | ||
| relative_url = "%s/%s" % (cls.KILLBILL_API_ACCOUNTS_PREFIX, account_id) | ||
| query_params = { | ||
| 'accountWithBalance': False, |
There was a problem hiding this comment.
Could you make these configurable?
killbill/payment_method.py
Outdated
| @@ -0,0 +1,58 @@ | |||
| # | |||
| # Copyright 2018 Federico Torresan | |||
There was a problem hiding this comment.
We would ask you to assign copyright to The Billing Project, LLC instead.
There was a problem hiding this comment.
Ok, I add The Billing Project, LLC to the copy line.
|
Ok, I've done the required changes. |
# Conflicts: # killbill/account.py # killbill/resource.py
killbill/payment_method.py
Outdated
| @@ -0,0 +1,59 @@ | |||
| # | |||
| # Copyright 2018 Quentral S.r.l. | |||
There was a problem hiding this comment.
Sorry if I wasn't clear: we require a full copyright assignment for contributions (i.e. single copyright line to The Billing Project, LLC). This is to avoid potential problems in the future (e.g. future claims).
There was a problem hiding this comment.
I've seen in the other files that the copy is shared also with other companies (Groupon ecc..) that are involved in the library creation. Considering that I've updated the library during the work time of Quentral s.r.l., I need to check with my CEO if is it fine to let the copy only to The Billing Project, LLC.
There was a problem hiding this comment.
The companies currently listed are the major sponsors of the project.
We insist on a full copyright assignment, especially on such small changes, because our project doesn't have the resources to track down individual authors for a license to redistribute the code.
I know this is a bit annoying but it is to make our life, as maintainers, easier, and to protect the project moving forward.
There was a problem hiding this comment.
I'm not sure this contribute will become a "small change" (I have to add some other classes and methods in the near future), but I talked yesterday with my CEO and it is fine to remove our copy line.
In the last commit you find the line removed.
killbill/payment_method.py
Outdated
| @@ -0,0 +1,59 @@ | |||
| # | |||
| # Copyright 2018 Quentral S.r.l. | |||
There was a problem hiding this comment.
Hi pierre,
I've done all the changes you told me.
Please check if you need other changes or is it ok!
2 participants
Hi,
if you print the Account object the python interpreter raise this exception.
RuntimeError: maximum recursion depth exceeded
This pull request fix the problem.
Best,
Federico