Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When TeaCache4HunyuanVideo? #233

Open
shivshankar11 opened this issue Dec 29, 2024 · 10 comments
Open

When TeaCache4HunyuanVideo? #233

shivshankar11 opened this issue Dec 29, 2024 · 10 comments

Comments

@shivshankar11
Copy link

https://github.com/LiewFeng/TeaCache/tree/main/TeaCache4HunyuanVideo

@jepjoo
Copy link

jepjoo commented Dec 29, 2024

This works for me although not with Enhance-a-vid:
#226

@Fredd4e
Copy link

Fredd4e commented Dec 29, 2024

Works for me too, however it does not seem to work with the smaller fp8 model, and also as you say not with enhance a video.

@ctf05
Copy link

ctf05 commented Dec 30, 2024

I found the enhance a video bug today. Im going to look into it sometime in the next two days. Other than that, I think it works fine. Tell me if there are any other bugs. It works on fp8 for me.

@Fredd4e
Copy link

Fredd4e commented Dec 30, 2024

I did some more testing, as i should have done beforehand.
Turns out its the auto cpu offload that does not work well for me with fp8 model. Apologies :)

@kroketagamer
Copy link

Hello, How do you do it? workflow?

@ctf05
Copy link

ctf05 commented Dec 30, 2024

Hello, How do you do it? workflow?

Im not at my pc to give a workflow right now but its pretty easy. Pull the PR branch talking about teacache to your custom nodes. Teacache is not yet in the main repo branch. It adds a new node named TeaCache. Connect this to the video sampler. Values between .1- .2 seem best for a speed to quality ratio.

@ctf05
Copy link

ctf05 commented Dec 30, 2024

I did some more testing, as i should have done beforehand.
Turns out its the auto cpu offload that does not work well for me with fp8 model. Apologies :)

All good. Glad it works. :)

@kroketagamer
Copy link

Hello, How do you do it? workflow?

Im not at my pc to give a workflow right now but its pretty easy. Pull the PR branch talking about teacache to your custom nodes. Teacache is not yet in the main repo branch. It adds a new node named TeaCache. Connect this to the video sampler. Values between .1- .2 seem best for a speed to quality ratio.

My Video Samplet node doesn't have the input for Teacache, I have the node but no connector on the video sampler

@Fredd4e
Copy link

Fredd4e commented Dec 30, 2024

I do have a question, I just dont seem to be able to get any decent results, I only have an GTX 1080ti and have been using SDPA since my old gpu dont support the faster thing. Does this work with SDPA or could that be why my results look like its been through no more than 2 iterations?

Any ideas?

@0000111100001111
Copy link

This works for me although not with Enhance-a-vid: #226

That PR is just giving me tensor location issues. Is it maybe not gonna be compatible with block swap?

Expected all tensors to be on the same device, but found at least two devices, cpu and cuda:0! (when checking argument for argument mat1 in method wrapper_CUDA_addmm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants