Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve compatibility between server and client #143

Open
NiklasRentzCAU opened this issue Jun 7, 2023 · 0 comments
Open

Improve compatibility between server and client #143

NiklasRentzCAU opened this issue Jun 7, 2023 · 0 comments
Labels
enhancement New feature or request klighd-core klighd-vscode requires server change This change is linked to some change on the server side implementation in KLighD

Comments

@NiklasRentzCAU
Copy link
Member

If the server or client has an API-breaking change and both KLighD and klighd-vscode are released, VS Code will automatically update the klighd-vscode version, whereas the server needs to be updated to the latest KLighD version manually, thus possibly leading to working installations in VS Code to suddenly break without notice. A current workaround is to manually force to use an old klighd-vscode release instead.

A solution to this problem is that the server should always notify klighd-vscode about its version in the init message so that klighd-vscode can warn the user about an incompatible version and possibly also disable new features related to that new release unless the server version is compatible.
Special case to note: If the server does not provide a version number (as of the current release), set it accordingly on the client.

@NiklasRentzCAU NiklasRentzCAU added enhancement New feature or request klighd-vscode klighd-core requires server change This change is linked to some change on the server side implementation in KLighD labels Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request klighd-core klighd-vscode requires server change This change is linked to some change on the server side implementation in KLighD
Projects
None yet
Development

No branches or pull requests

1 participant