-
Notifications
You must be signed in to change notification settings - Fork 14
Conversation
Hi @hmueller01 Thanks for your new PR for Captive-Portal. As this is Async library, I suggest you change to use ESPAsyncDNSServer. Check the mods in ESPAsync_WiFiManager to use AsyncDNSServer instead of DNSServer. Check the changes in Comparing changes Waiting for your modified PR. BR, |
HI @hmueller01 Please also help add your PRs into sync twin library ESP_WiFiManager_Lite BR, |
Ah, ok. I didn't knew the ESP_WiFiManager_Lite ... I used DNSServer as you already included that (I do not know what the dependency was/is). But ok, you are right. I'll change this in the next days. |
Ok, I switched to AsyncDNSServer. Sync with non Async project ESP_WiFiManager_Lite follows ... |
Merged. Thanks for your contribution. Looking forward to receiving more PRs from you. Best Regards, |
Hi @hmueller01 The new ESPAsync_WiFiManager_Lite releases v1.9.1 has just been published. Your contribution is noted in Contributions and Thanks Best Regards, Release v1.9.1
|
add CaptivePortal to Config Portal