Skip to content
This repository has been archived by the owner on Feb 4, 2023. It is now read-only.

Captive portal #22

Merged
merged 11 commits into from
Dec 28, 2022
Merged

Captive portal #22

merged 11 commits into from
Dec 28, 2022

Conversation

hmueller01
Copy link
Contributor

add CaptivePortal to Config Portal

@khoih-prog
Copy link
Owner

khoih-prog commented Dec 23, 2022

Hi @hmueller01

Thanks for your new PR for Captive-Portal.

As this is Async library, I suggest you change to use ESPAsyncDNSServer.

Check the mods in ESPAsync_WiFiManager to use AsyncDNSServer instead of DNSServer.

Check the changes in Comparing changes

Waiting for your modified PR.

BR,

@khoih-prog
Copy link
Owner

HI @hmueller01

Please also help add your PRs into sync twin library ESP_WiFiManager_Lite

BR,

@hmueller01
Copy link
Contributor Author

Ah, ok. I didn't knew the ESP_WiFiManager_Lite ...
Maybe I change to this, as I have lots of crashes in my code with ESPAsyncWebServer. Too bad that me-no-dev drops support/development of his excellent work.

I used DNSServer as you already included that (I do not know what the dependency was/is). But ok, you are right. I'll change this in the next days.

@hmueller01
Copy link
Contributor Author

Ok, I switched to AsyncDNSServer. Sync with non Async project ESP_WiFiManager_Lite follows ...

@khoih-prog khoih-prog merged commit 326c62e into khoih-prog:main Dec 28, 2022
@khoih-prog
Copy link
Owner

Merged. Thanks for your contribution. Looking forward to receiving more PRs from you.

Best Regards,

khoih-prog added a commit that referenced this pull request Dec 28, 2022
### Release v1.9.1

1. Add `Captive Portal` using AsyncDNSServer. Check [Captive portal #22](#22)
2. Cleanup reset code. Check [cleanup reset code #23](#23)
3. Periodical code clean-up
@khoih-prog
Copy link
Owner

Hi @hmueller01

The new ESPAsync_WiFiManager_Lite releases v1.9.1 has just been published. Your contribution is noted in Contributions and Thanks

Best Regards,


Release v1.9.1

  1. Add Captive Portal using AsyncDNSServer. Check Captive portal #22
  2. Cleanup reset code. Check cleanup reset code #23
  3. Periodical code clean-up

@khoih-prog khoih-prog mentioned this pull request Dec 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants