Skip to content

Conversation

@khellang
Copy link
Owner

No description provided.

Update CI workflow to upload both .nupkg and .snupkg files:
- Artifact upload now includes both package types using multi-line path
- GitHub Packages push uses *.*nupkg pattern to match both extensions

Symbol packages (.snupkg) contain debugging information that helps
developers debug into the library code. Publishing them to GitHub
Packages enables a better debugging experience.
Add MinVer 6.0.0 package for automatic version calculation from Git tags:
- MinVer automatically determines version from Git tags (e.g., v6.1.0)
- Generates proper semantic versions with pre-release identifiers
- Integrates with build height for automatic patch increments
- VersionPrefix (6.1.0) serves as fallback when no tags exist
- MinVerTagPrefix set to 'v' to match conventional tag format

Benefits:
- Eliminates manual version updates in project files
- Automatic versioning in CI/CD pipelines
- Proper pre-release versioning for feature branches
- Consistent with deterministic builds

Microsoft.SourceLink.GitHub is already at latest version 8.0.0.

Version calculation examples:
- On tag v6.1.0: produces version 6.1.0
- After tag: produces version 6.1.1-alpha.0.{height}
- On branch: includes branch name in pre-release identifier
Copilot AI review requested due to automatic review settings November 24, 2025 19:07
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.31%. Comparing base (7876e90) to head (54ad926).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #267   +/-   ##
=======================================
  Coverage   86.31%   86.31%           
=======================================
  Files          29       29           
  Lines        2053     2053           
  Branches      247      247           
=======================================
  Hits         1772     1772           
  Misses        250      250           
  Partials       31       31           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot finished reviewing on behalf of khellang November 24, 2025 19:08
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces MinVer for automatic versioning based on Git tags. MinVer calculates the package version from Git tags, with VersionPrefix serving as a fallback when no tags exist.

  • Adds MinVer package reference with Git tag-based versioning configuration
  • Updates CI workflow to include symbol packages (.snupkg) in artifacts and push operations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/Scrutor/Scrutor.csproj Adds MinVer package reference and configuration with tag prefix "v"
.github/workflows/build.yml Updates artifact paths and push patterns to include symbol packages
Comments suppressed due to low confidence (1)

.github/workflows/build.yml:18

  • MinVer requires Git history to calculate versions from tags. The checkout action needs fetch-depth: 0 to fetch the full Git history. Without this, MinVer will only see the shallow clone and may not find version tags, causing it to fall back to the default version.
            - name: Checkout
              uses: actions/checkout@v4

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@khellang khellang merged commit ce444a5 into master Nov 24, 2025
10 checks passed
@khellang khellang deleted the claude/upgrade-to-dotnet-01HBTW8qPH6GH7H2tV8LnYVo branch November 24, 2025 19:09
This was referenced Nov 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants