-
-
Notifications
You must be signed in to change notification settings - Fork 273
Add keyed service registration support #260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
khellang
merged 4 commits into
khellang:master
from
A-Ebrahimzadeh-dev:feature/keyed-services
Nov 24, 2025
Merged
Add keyed service registration support #260
khellang
merged 4 commits into
khellang:master
from
A-Ebrahimzadeh-dev:feature/keyed-services
Nov 24, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Hi @A-Ebrahimzadeh-dev! 👋🏻 This looks like a good contribution, thank you! 🙏🏻 Would you be able to add some tests? |
Add tests and fix service key detection issue
Contributor
Author
Hi 👋🏻 Thanks a lot for the feedback! I’ve added the tests as requested. Please let me know if you’d like me to improve or adjust anything 🙏 |
khellang
approved these changes
Nov 24, 2025
This was referenced Nov 24, 2025
This was referenced Dec 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for registering services with a service key in Scrutor.
Currently, Scrutor does not provide a way to register keyed services.
With this change, developers can specify a key when registering a service via
ServiceDescriptorAttribute.Changes
ServiceDescriptorAttributeto allow an optionalServiceKeyproperty.ServiceKeyif provided.Motivation
Adding keyed services allows more flexible dependency injection scenarios,
such as having multiple implementations of the same interface and selecting them by key at resolution time.
Example