Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: Prevent multiple users editing the same post #3795

Closed
lmshaffe opened this issue Dec 14, 2016 · 6 comments
Closed

Enhancement: Prevent multiple users editing the same post #3795

lmshaffe opened this issue Dec 14, 2016 · 6 comments

Comments

@lmshaffe
Copy link

Steps to reproduce the behavior

Have two users on the same post page editing the post. Have one user make changes and save and then have the second user save their changes. User 1's changes are now gone.

Expected behavior

If two users are in the same post, only the first user can have access to edit it

Actual behavior

@freew01f
Copy link

why can 2 users edit the same post?
if u want to do it, u have to add version control to it

in normally, only author can edit the post

@lmshaffe
Copy link
Author

We have experienced that anyone with access to keystone can edit a post regardless of who the author is. We had two different users editing the same post at the same time on their own respective computers.User 1 saved and their changes were saved. User 2 saved last and their changes overwrote what user 1 just did.

Have you experienced different with 2 users trying to edit a post at the same time?

@freew01f
Copy link

it is not easy to handle~
I think u have to consider to use version control~
this way u can merge diff version of post ~

@lmshaffe
Copy link
Author

I am sure it is not easy, that is simply why I posed this as a possible enhancement feature to the team.

@webteckie
Copy link
Contributor

I think this will be possible when dynamic permissions support (see keystonejs/keystone-test-project#21) is in.

@Noviny
Copy link
Contributor

Noviny commented Oct 3, 2017

There are two issues here. First, do all users have edit rights, and second, if one person has a post open, no person on another computer can edit it.

The first is solved by us adding a permissions scheme. There is an existing issue/discussion around this.

If what you are after is the second, that's a complex piece of architecture (multi-client state shared with server with a notion of checking something out), which we are not looking to build into the core of keystone.

Closing this issue in favor of existing permissions discussion.

@Noviny Noviny closed this as completed Oct 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants